Repository navigation
Dev to main, 14th Sep, 2026 - #861
Merged
Merged
Conversation
Main to dev sync
docs: document OTLP request size limits
Four real failure modes had no coverage: a process-wide LangChain instrumentor silently pulling unrelated calls into the wrong project, suppress_tracing dropping (not moving) spans and breaking under async with, no way to cap oversized span attributes short of an image-only truncation, and a cookbook page claiming its trace rows show model/cost when its manual root span never sets them. - integrations/traceai/langchain.mdx: warn that the instrumentor patches the process globally and a second instrument() is a no-op - sdk/tracing/context-helpers.mdx: suppress_tracing drops spans rather than rerouting them, and async with is unsupported and can leak suppression past the block - sdk/tracing/trace-config.mdx: new "Cap attribute size" section for OTEL_ATTRIBUTE_VALUE_LENGTH_LIMIT / register(span_limits=...) - sdk/tracing/mask-span-attributes.mdx: fix the "removes or truncates" claim; only base64 images truncate - cookbook/observe-langgraph-agent-and-obtain-insights.mdx: fix the claim that every row shows model and cost - observe/reference/export-formats.mdx, observe/troubleshooting/ no-traces-appearing.mdx: repoint their oversized-payload advice at the new cap-attribute-size section instead of masking, which never trimmed non-image attributes
The four fixes in the previous commit were scattered across reference pages a customer has to already know exist. This adds one dedicated troubleshooting page matching the shape of what someone actually sees first: traces from other code mixed in, or a trace with Type "unknown", Cost $0.00, and no Session/User despite real LLM calls underneath it. Bundles all four causes and their fixes in one place — shared instrumentor, suppress_tracing dropping vs rerouting, root-only cost/model on the row, and oversized attributes — plus diagnostic code and a smoke test, following the same frontmatter/structure as the existing troubleshooting pages (missing-attributes.mdx, dashboard-numbers-look-wrong.mdx). Added to the Troubleshooting nav group. Verified locally: page renders, every cross-page anchor (#4-instrument-your-project, #suppress-tracing, #cap-attribute-size) resolves, and audit-links reports 0 broken nav/content links.
…n-gaps Fix instrumentation doc gaps found while diagnosing Whatfix's traces
commitPirate
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotion PR. Everything in it is already reviewed and merged to
dev; this moves it tomainso it deploys to prod.devis 9 commits ahead ofmain:devon 09-09, never promoted since.suppress_tracingasync/drop warning, a new "Cap attribute size" section, a mask-span-attributes fix, and a new troubleshooting page (noisy-or-incomplete-traces.mdx).Why it needs its own PR
Merging to
devdoes not publish. Both of the above are live ondevand invisible in prod until this merges.Note
The head of this PR is
dev, so it carries whateverdevholds when it merges. Khushal is AFK for the next ~1.5 hours, so this is going to Nosang for review instead, with Khushal added as a reviewer too.