feat: add kmp_build_mode input to ios-kmp-selfhosted-test - #114
Draft
ssestak wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
KMP projects generated from the template default to building all XCFramework slices (
iosArm64+iosSimulatorArm64) —shared/app/build.gradle.ktsfalls back to"all"when-PkmpBuildModeis not passed, and this workflow never setsKMP_BUILD_MODE, so the KMPMakefilenever forwards it.The
Fastlane Teststep that follows only ever runs simulator tests, so theiosArm64device slice is compiled and linked on every PR run and then never used. Ontetadrogerie-kmptheBuild KMP Packagestep takes ~3 min per PR; roughly half of that is the unused device slice (Kotlin/Native link time scales with the number of slices).Change
New optional
kmp_build_modestring input, exported asKMP_BUILD_MODEon theBuild KMP Packagestep. Callers whose PR checks only run simulator tests can pass:Backwards compatibility
''→ the env var is empty → GNU make'sifdef KMP_BUILD_MODEtreats an empty variable as undefined →-PkmpBuildModeis not passed → existing behavior (all) is unchanged for every current caller.KMP_BUILD_MODEhandling simply ignore the env var.🤖 Generated with Claude Code
https://claude.ai/code/session_019xxj9PVQVi9z8nB6rGHbEg