Fix: fxserver paths validation#69
Open
Maximus7474 wants to merge 3 commits into
Open
Conversation
paths -> the basic check ignored if the path was a directory or file making the system believe it's valid when it isn't
Maximus7474
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an oversight in #63 where auto detect was validating the executable path when it was only a directory, the commits fix this oversight by reusing the
ConfigManager.checkFXServerPaths(exec, data)within the detection to not only properly validate but also provides absolute paths for the values.Alongside this fix, it also expands the checked paths for linux executables. Instead of requiring the path to
opt/cfx-server/it will also work to the parent folder ofalpine, so in sum it will accept & auto-complete the following:./fxServer/./fxServer/alpine/opt/cfx-server/fxserver./fxServer/alpine/opt/cfx-server/./fxServer/alpine/opt/cfx-server/fxserverGenerative AI was used in the creation of the changes of this PRTests
Additional Notes
This is useful for allowing auto-detect for cli-installer & #68