Repository navigation
feat: add problemFor(raw) to preserve the observed HTTP status - #50
Merged
Merged
Conversation
classify() returns only the code, so a code registering [400, 422] made toProblemDetails() emit 400 even when the failure was a 422. problemFor() classifies and serializes in one step, using the status that matched; options.status still overrides. Additive API, tested. Fixes the multi-status loss identified in the review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the multi-status loss: a code with
httpStatus: [400, 422]now emits the 422 that actually matched when the caller usesproblemFor(raw). Additive;toProblemDetailsis unchanged. 346 tests pass.