Repository navigation
TST cover voxline, slice-plane and lighting shader code - #762
Open
kroq-gar78 wants to merge 4 commits into
Open
kroq-gar78 wants to merge 4 commits into
kroq-gar78 wants to merge 4 commits into
Conversation
- Link surface_pixel with voxline on, once per color type. - Link the three main variants the slice planes use. - Replace Any annotations with precise types.
The test scene had no lights, so all lighting GLSL compiled away. Build it from the viewer's Axes3D instead, and assert the lighting code stays compiled. Also fail, rather than skip, when the test page throws while loading.
The invalid-GLSL test now takes the same path as the real shaders.
kroq-gar78
force-pushed
the
tests-webgl-shader-voxline
branch
from
October 9, 2026 01:53
3048c4d to
6663d34
Compare
- Link both surface shaders without a white matter surface (volume=0), including voxline's non-cortical-sheet branch. - Fail on page script errors thrown after load, not only during it. - Dispose each linked material and geometry, and inline linkResult.
kroq-gar78
marked this pull request as ready for review
October 27, 2026 02:27
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_webgl_shaders.pynever linkedvoxline, the slice planes'mainshader, or any shader's lighting code, so a compile error in any of them would only show up as a blank viewer.Changes
surface_pixelshader withvoxlineon, once per color type.mainshader that the slice planes use.volume=0).Axes3D, so shaders compile with the viewer's lights. Before, the scene had no lights and all lighting code compiled away. A new assertion makes sure it stays compiled. (Most of the changes toPAGEare for this.)Anywith precise types.Testing
test_webgl_shaders.py: 101 passed.Follow-ups
volume=0isn't linked.voxline_color/voxline_widthhave no effect on surfaces.