perf: reduce Icon List item mount cost in widgets editor#3728
Open
bfintal wants to merge 1 commit into
Open
Conversation
Use lightweight SvgIcon for inherited parent icons and unselected items, resolve block editor selectors on demand in useEnter, and sync list context attributes immediately without delayed store writes. Fixes #3062 Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Pushed latest commit |
🤖 Pull request artifacts
|
|
Size Change: +51 B (0%) Total Size: 2.63 MB 📦 View Changed
ℹ️ View Unchanged
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe PR updates SVG ChangesIcon list editor flow
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
The change includes the removal of the 300ms timeout for an immediate syncing. The fix persists against #3333. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3062 — slowdown on Appearance → Widgets when many Icon List blocks are present.
The Icon List revamp uses one
icon-list-iteminner block per line, each mounting the full Stackable edit stack. Widgets loads all widget areas at once, so hundreds of items mount together.Changes
ListItemIcon(list-item-icon.js) — lightweight icon renderingSvgIconwith<use>reference (no fullIconcomponent)SvgIconIcon(picker still works)useEnter(util.js) — removed whole-storeuseSelectsubscription; block editor selectors resolved viaselect()only on Enter keypressedit.js— immediate non-persistent sync ofordered/parentUniqueId(removed 300ms delayedsetAttributesper item on load); parent block lookup on demand for backspace mergeIcon(block-components/icon/index.js) — handle<use>SVG values in editor; show picker cursor whenopenEvenIfUnselectedExpected impact
Test plan
A. Widgets — primary regression gate (required)
develop(subjective + DevTools Performance optional)B. Icon List — inherited parent icon (most common case)
On a post and in Widgets:
Icon)C. Icon List — per-item custom icon
D. List editing behavior
developE. Ordered vs unordered
orderedattribute sync)F. Nested & transformed lists
G. Other editor contexts
H. Icon component regression (touched file)
On blocks that use
IconwithopenEvenIfUnselected(e.g. Button, Feature):<use>-based icons render (Icon List selected item with inherited def)I. Frontend parity (smoke)
Out of scope
useBlockCssGenerator/generatedCssmount cost (follow-up)Made with Cursor
Summary by CodeRabbit
Bug Fixes
New Features