Skip to content

fix: hydrate private config during deploy - #33

Merged
frostebite merged 1 commit into
mainfrom
fix/deploy-private-config
May 7, 2026
Merged

frostebite merged 1 commit into
mainfrom
fix/deploy-private-config

Conversation

@frostebite

@frostebite frostebite commented May 7, 2026 •

Copy link
Copy Markdown
Member

Summary

  • stop deploy from copying public config.json after config moved to private repo
  • copy config.example.json and preserve/hydrate live config from game-ci/help-bot-config
  • reset handled external command exit codes so fallback config paths do not fail the step

Verification

  • yarn oxfmt --check .github/workflows/deploy.yml
  • git diff --check

Fixes the Deploy help-bot failure in run 25462336540 where Sync live tree failed because config.json no longer exists in the public checkout.

Summary by CodeRabbit

  • Chores
    • Deployment process now supports private configuration management with graceful fallback to default settings when unavailable, improving deployment reliability and flexibility.

@coderabbitai

coderabbitai Bot commented May 7, 2026 •

Copy link
Copy Markdown

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 312c0eee-f0e9-4253-88fc-fa95b1925d4a

📥 Commits

Reviewing files that changed from the base of the PR and between d12f284 and 903c6a1.

📒 Files selected for processing (1)
  • .github/workflows/deploy.yml

📝 Walkthrough

Walkthrough

The deploy workflow's "Sync live tree" step changes configuration sourcing from directly copying the repo's config.json to syncing a private configuration repository (game-ci/help-bot-config) and using its config.json when available, with fallback to config.example.json on unavailability or sync failure.

Changes

Configuration Sync Strategy

Layer / File(s) Summary
Config Source Migration
.github/workflows/deploy.yml
Removed direct copying of repo config.json from file list; added logic to sync private game-ci/help-bot-config repository via git pull (if exists) or clone (if new).
Private Configuration Resolution
.github/workflows/deploy.yml
Copies private config.json from synced repo into deployment directory; otherwise uses config.example.json from main repo as fallback.
Error Handling & Resilience
.github/workflows/deploy.yml
Catch block ensures config.example.json is deployed when private repo sync fails and no existing config.json is present, preventing deployment failure due to missing configuration.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • game-ci/help-bot#16: Also modifies the same deploy workflow and config.json handling strategy during deployment.

Poem

🐰 A quest for config, both hidden and clear,
Private repos sync from far and near,
When secrets vanish, examples appear,
Fallbacks ensure no deployment fear! 🌟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: modifying the deploy workflow to load private configuration instead of public config.json.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/deploy-private-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@frostebite
frostebite merged commit 860ccd2 into main May 7, 2026
1 of 2 checks passed
@frostebite
frostebite deleted the fix/deploy-private-config branch May 7, 2026 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant