tcache: producer floors and consumer tails - #306
Merged
Merged
Conversation
alexX512
reviewed
Sep 25, 2026
vladimir-ea
force-pushed
the
ve/tache_tails
branch
from
September 25, 2026 13:46
f8bc2c8 to
cd98b53
Compare
added 2 commits
September 25, 2026 15:41
ninaiiad
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a mechanism for consumers to accurately set their tail value without skipping
TCacheReads that arrive out of order:TCacheReadnow includes an emitter id and afloorvalueTCacheHeadTCacheReads, theflooris their own consumer tail.the value of
floormeans: I will not produce an event containing aTCacheReadwith aseqlower thanfloor.floors perTCacheper emittingTile(emitters); combined with the locally acquired reads this is used to calculate the tailThis mechanism has the following consequences:
TCacheReads that are held or stored across tile loops must be acquiredTile::try_init()).loop_start()at the start of every tile loop - this fixes the producer'sfloorfor the current loop