Conversation
Collaborator
|
out of interest: have you tried calling the beacon apis? |
vladimir-ea
reviewed
Sep 25, 2026
vladimir-ea
reviewed
Sep 25, 2026
vladimir-ea
reviewed
Sep 25, 2026
| for (&peer_id, _) in subscribers.take(count) { | ||
| crate::counters::GossipTopicCounters::sent(topic); | ||
| emit(PeerControl::P2pSend(P2pSend::Gossip(GossipMsgOut { peer_id, tcache }))); | ||
| } |
Collaborator
There was a problem hiding this comment.
is this something recommended in the specs?
Collaborator
Author
There was a problem hiding this comment.
in the specs we're not fanning out just to meshed peers, yes
Collaborator
Author
There was a problem hiding this comment.
this is based on
https://github.com/libp2p/specs/blob/master/pubsub/gossipsub/gossipsub-v1.1.md#flood-publishing + https://github.com/libp2p/specs/blob/master/pubsub/gossipsub/gossipsub-v1.0.md#message-processing:~:text=If%20the%20router%20is%20subscribed,send%20the%20message%20to%20each.
we only send to peers not from mesh if the mesh is thin or we're not subscribed to the topic
vladimir-ea
approved these changes
Sep 25, 2026
ninaiiad
force-pushed
the
ng/subnet-sub
branch
from
September 26, 2026 14:30
877146a to
72090b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.