Repository navigation
test: bind early session recovery checks to durable admission (closes #875) - #876
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Early-session recovery can replay a durable message before its original admission callback runs. That valid ordering returns
delivered, which the old recovery test rejected before checking whether the continuation actually recovered.The eight-case matrix now covers Claude and Codex, timeout and worker termination, and ordinary and forced replay-first admission. It binds the continuation to its durable receipt and exact provider job, verifies the old agent exits and the first job is terminal, then checks one replacement job, a new generation, the retained conversation arc and native handle, and completed message state. The forced ordering uses the real replay path with guaranteed coordinator cleanup.
Validation: focused seeds 1, 12345, 777 and the originally observed 718792; all five local gates; independent review. CI must pass on the updated PR head before merge.
These are deterministic fake-provider tests. They do not establish native subprocess settlement; the fixture explicitly records terminal job state. Production behavior and authority are unchanged.
Closes #875.