feat: show Mempool data source in Settings->About - #2612
visawestern wants to merge 1 commit into
Conversation
Displays the configured mempool API URL (info.mempoolUrl, already served by GET /api/info) as a 'Mempool Data Source' row right after 'Chain Data Source', matching the existing LSPS2 ExternalLink style. Closes getAlby#2548
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe About screen now displays a “Mempool Data Source” entry with the configured URL as an external link when ChangesMempool data source display
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to The About page displays the configured Mempool source when available. No merge-blocking issue was identified. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change adds a link to the configured mempool source, not a new service or permission. Opening it requires a user click. No introduced security issue was established, though control of the configured destination was not fully assessed. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
Adds the configured Mempool data source to Settings → About, right after the "Chain Data Source" row. The backend already serves
mempoolUrlviaGET /api/info(seeconfig/config.goGetMempoolUrl()), but the About screen only used it for LSP node links — there was no dedicated row showing which mempool instance is in use.Changes
frontend/src/screens/settings/About.tsx(+12): conditionalinfo.mempoolUrlblock rendering a "Mempool Data Source"ExternalLink(reuses existingExternalLink+ExternalLinkIcon, same style as the LSPS2 link). No new imports/dependencies, no backend changes.Screenshots
N/A (one conditional row, same styling as adjacent rows).
Test plan (real, run locally on this branch)
yarn install --frozen-lockfile— OKyarn prepare:http— OKyarn tsc:compile(tsc --noEmit) — exit 0, cleanyarn eslint src/screens/settings/About.tsx --max-warnings 0— exit 0, cleanyarn lint:js(eslint src --max-warnings 0) — exit 0, cleanyarn prettier --check src/screens/settings/About.tsx— passgit apply --checkof the patch on pristine base7b3fcaa— passesgo test ./...skipped: backend untouched (frontend-only change)Closes #2548
Summary by CodeRabbit