Skip to content

feat: show Mempool data source in Settings->About - #2612

Open
visawestern wants to merge 1 commit into
getAlby:masterfrom
visawestern:mempool-about-2548
Open

visawestern wants to merge 1 commit into
getAlby:masterfrom
visawestern:mempool-about-2548

Conversation

@visawestern

@visawestern visawestern commented Sep 27, 2026 •

Copy link
Copy Markdown

What

Adds the configured Mempool data source to Settings → About, right after the "Chain Data Source" row. The backend already serves mempoolUrl via GET /api/info (see config/config.go GetMempoolUrl()), but the About screen only used it for LSP node links — there was no dedicated row showing which mempool instance is in use.

Changes

  • frontend/src/screens/settings/About.tsx (+12): conditional info.mempoolUrl block rendering a "Mempool Data Source" ExternalLink (reuses existing ExternalLink + ExternalLinkIcon, same style as the LSPS2 link). No new imports/dependencies, no backend changes.

Screenshots

N/A (one conditional row, same styling as adjacent rows).

Test plan (real, run locally on this branch)

  • yarn install --frozen-lockfile — OK
  • yarn prepare:http — OK
  • yarn tsc:compile (tsc --noEmit) — exit 0, clean
  • yarn eslint src/screens/settings/About.tsx --max-warnings 0 — exit 0, clean
  • yarn lint:js (eslint src --max-warnings 0) — exit 0, clean
  • yarn prettier --check src/screens/settings/About.tsx — pass
  • git apply --check of the patch on pristine base 7b3fcaa — passes
  • go test ./... skipped: backend untouched (frontend-only change)

Closes #2548

Summary by CodeRabbit

  • New Features
    • The About screen now displays the mempool data source as a clickable external link when available.

Displays the configured mempool API URL (info.mempoolUrl, already
served by GET /api/info) as a 'Mempool Data Source' row right after
'Chain Data Source', matching the existing LSPS2 ExternalLink style.

Closes getAlby#2548
@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 4f3e47f6-d4b7-4937-bd04-ad1e9927c7e4

📥 Commits

Reviewing files that changed from the base of the PR and between 7b3fcaa and 73b81cb.

📒 Files selected for processing (1)
  • frontend/src/screens/settings/About.tsx

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.


📝 Walkthrough

Walkthrough

The About screen now displays a “Mempool Data Source” entry with the configured URL as an external link when info.mempoolUrl is present.

Changes

Mempool data source display

Layer / File(s) Summary
Conditional mempool source entry
frontend/src/screens/settings/About.tsx
When info.mempoolUrl is present, the About screen shows the “Mempool Data Source” label and URL link with an icon. Otherwise, it omits the entry.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Feature

Suggested reviewers: rolznz

Merge Risk: ⚪ Minimal · up to 73b81

The About page displays the configured Mempool source when available. No merge-blocking issue was identified.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 73b81

The change adds a link to the configured mempool source, not a new service or permission. Opening it requires a user click. No introduced security issue was established, though control of the configured destination was not fully assessed.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The new exposure is a user-clickable destination on About even without LSPS2 information. The URL was already present in the info response and used by About for LSPS2 links.

Trust Boundaries and Controls

  • inferred — The inspected flow crosses from deployment configuration to an external destination on user click. It does not show an About-screen input controlling that destination or a new privileged action; permissions governing the deployment setting remain unverified.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: displaying the Mempool data source in Settings → About.
Linked Issues check ✅ Passed Issue #2548 requires the configured Mempool data source to appear in Settings → About. The change adds a conditional “Mempool Data Source” row after “Chain Data Source” and renders info.mempoolUrl w…
Out of Scope Changes check ✅ Passed The whole-PR diff changes only frontend/src/screens/settings/About.tsx. The change directly supports issue #2548 and does not add unrelated backend, UI, or configuration changes.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Mempool data source to Settings->About

1 participant