Repository navigation
chore(spec): synchronize Lago OpenAPI - #39
Merged
Merged
Conversation
groyoh
previously approved these changes
Nov 5, 2026
Three tests compared the embedded spec version with the literal `1.52.1`, so
a drift that changes the version failed them. They now read
`generated.SpecVersion`; `TestGeneratedManifestEmbedsPinnedSpecIdentity` still
checks the generated code against `spec/operations.json`.
The body types test skipped body fields that share a name with a path
parameter. Path parameters are positional arguments, so a required body field
such as `--code` on `POST /plans/{code}/charges` keeps its own flag and must be
passed. Only query and header parameters are skipped now.
`TestPinnedOperationsLoaded` only checked that the generated package has a version, a SHA-256 and operations. `TestGeneratedManifestEmbedsPinnedSpecIdentity` already checks them against `spec/operations.json`, and the parity test keeps the operation-count guard.
groyoh
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The CLI commands are generated from a copy of the Lago OpenAPI document kept in
spec/openapi.yaml. A daily job compares this copy with the published document (https://swagger.getlago.com/openapi.yaml) and opens this PR when they differ.Description
spec/openapi.yamlwas replaced with the published document. The generated code, the command reference, the man pages and the shell completions were generated again from it.1.57.00548d030b8384508d3638203c453f704565a7df954f4db9e42deadd554b5069e