ci: the licence gate read a disjunction as a conjunction - #17
Merged
Conversation
Composer lists a package's licences as an array meaning OR — the package is offered under any of them and the consumer picks one. This gate iterated that array and failed as soon as a single entry was disallowed, which turned "you may use this under BSD-3-Clause" into "this drags in GPL". The defect arrives inert here: nothing in this tree is dual-licensed today. It is corrected anyway, because it is a defect of a class rather than of a site, and correcting it while the tree is at peace is cheaper than correcting it the day it bites. A package now passes when any one of its licences is allowed. What does not change is the treatment of a package that declares none: still a failure. Loosening how licences combine must not loosen what the gate is for — a disjunction of nothing but disallowed licences still fails. Battery and control in the greenhouse: evidence/0180.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thirty-eight repos carry a licence gate that reads Composer's licence array as a conjunction. It is a disjunction — a package offered under
BSD-3-Clause OR GPL-2.0-onlymay be used under BSD.Inert here today; corrected because it is a defect of a class. Battery, control and scope: greenhouse
evidence/0180.