fix(tracing): report late spans under nested sent spans - #1160
Draft
solnic wants to merge 1 commit into
Draft
Conversation
solnic
force-pushed
the
fix/otel-nested-orphan-promotion
branch
from
August 7, 2026 12:40
5eea88b to
ab63148
Compare
solnic
force-pushed
the
fix/otel-nested-orphan-promotion
branch
from
August 7, 2026 14:44
ab63148 to
40a2ec1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Async work often continues from a context captured inside a nested span (a handler deep in the trace), not the root. Sent markers now cover every span of a sent transaction, and post-send storage cleanup removes sent descendants at every depth — previously only direct children were removed, leaving stale records that swallowed late spans.
Screenshots are based on an e2e scenario where
finalize_batchis reported as a follow-up transaction under the nestedprocess_batchspan, starting ~0.5s after the 9ms request:Before
Notice that
finalize_batchis missing here.After
🎉
finalize_batchis correctly under the trace.