refactor(nextjs): Change ESM interop. to remove lazy loading#22193
Open
timfish wants to merge 3 commits into
Open
refactor(nextjs): Change ESM interop. to remove lazy loading#22193timfish wants to merge 3 commits into
timfish wants to merge 3 commits into
Conversation
timfish
changed the title
timfish
requested review from
andreiborza,
chargome,
isaacs,
mydea and
s1gr1d
and removed request for
a team
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
timfish
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code like this always points to an ESM/CJS interop issue:
sentry-javascript/packages/server-utils/src/orchestrion/bundler/webpack.ts
Line 53 in 8c6358a
This is caused by our repo-wide Rollup setting of
interop: 'esModule'. This is required for us to be able to monkey patch Node built-ins but causes the above issues with CJS dependencies that use the classic CJS default export (module.exports = fn).This PR overrides the
interopsetting for the suspect package and removes the lazy dependency loading.