fix(match_regex_list): handle empty string patterns without IndexError#6802
Open
hiro-nikaitou wants to merge 1 commit into
Open
fix(match_regex_list): handle empty string patterns without IndexError#6802hiro-nikaitou wants to merge 1 commit into
hiro-nikaitou wants to merge 1 commit into
Conversation
An empty string pattern in the regex list causes IndexError when accessing item_matcher[-1]. Skip empty string patterns in the loop to prevent the crash. Closes getsentry#6504
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty string pattern in the regex list causes an
IndexError: string index out of rangewhenitem_matcher[-1]is accessed. This is reachable through integrations like Celery (CeleryIntegration.exclude_beat_tasks) when users accidentally configure an empty pattern.Skip empty string patterns in the loop to prevent the crash. A pattern with no characters is a no-op anyway.
Closes #6504