Switch over to ucrt64 - #741
Merged
Merged
Conversation
dscho
force-pushed
the
switch-over-to-ucrt64
branch
4 times, most recently
from
September 10, 2026 21:58
d6f7fad to
8670707
Compare
When we started migrating Git for Windows from MINGW64 to UCRT64 in git-for-windows/git-sdk-64#117, we eventually also started to build the UCRT64 installers and published them. Now that this PR is merged, the order is reversed: the MINGW64 one is now on its way out and will only be built for a short while, with the official version being UCRT64. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Now that we've switched to UCRT64, it is _supposed_ to be missing. Apparently `dash.exe` bails when this happens, even if the test is in the conditional of the `if` construct. The `build-installers` arm already handled this gracefully, but the `makepkg-git` arm needs to handle this, too. While at it, log more verbosely what is happening in the invocation of the `please.sh` script. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
switch-over-to-ucrt64
branch
from
September 10, 2026 22:16
1b88919 to
32c75da
Compare
dscho
added a commit
that referenced
this pull request
Sep 10, 2026
I meant to include this in #741... Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to git-for-windows/git-sdk-64#117.