Merge main to v3 to prepare for v3.5.2

.github/actions/auth/README.md

@@ -21,6 +21,15 @@ Authenticate with Playwright and save session state. Supports HTTP Basic and for
 > [!IMPORTANT]
 > Don’t put passwords in your workflow as plain text; instead reference a [repository secret](https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/use-secrets#creating-secrets-for-a-repository).
 
+#### `ignore_https_errors`
+
+**Optional** Bool - whether to ignore HTTPS errors when logging in to hosts with self-signed certificates.
+
+[!WARNING]
+Enabling this disables TLS certificate validation for the authentication step itself. If an attacker can intercept traffic, they can present an untrusted certificate and capture submitted credentials (including HTTP Basic auth and form passwords) and resulting session cookies/storage.
+
+Use this only in trusted test/staging environments. For shared workflows, prefer a separate explicit opt-in for auth flows (for example, `auth_ignore_https_errors`) so certificate checks are not unintentionally disabled during credentialed requests.
+
 ### Outputs
 
 #### `auth_context`

.github/actions/auth/action.yml

@@ -11,6 +11,10 @@ inputs:
   password:
     description: "Password"
     required: true
+  ignore_https_errors:
+    description: "Whether to ignore HTTPS errors when logging in to hosts with self-signed certificates"
+    required: false
+    default: "false"
 
 outputs:
   auth_context:

.github/actions/auth/src/index.ts

@@ -15,6 +15,7 @@ export default async function () {
     const username = core.getInput('username', {required: true})
     const password = core.getInput('password', {required: true})
     core.setSecret(password)
+    const ignoreHttpsErrors = core.getInput('ignore_https_errors', {required: false}).toLowerCase() === 'true'
 
     // Launch a headless browser
     browser = await playwright.chromium.launch({
@@ -27,6 +28,7 @@ export default async function () {
         username,
         password,
       },
+      ...(ignoreHttpsErrors ? {ignoreHTTPSErrors: true} : {}),
     })
     page = await context.newPage()
 

.github/actions/file/src/generateIssueBody.ts

@@ -52,6 +52,7 @@ ${standardsLine}
   const body = `${categoryNotice}## What
 ${describeFinding(finding)}
 
+${finding.ruleId ? `**Rule:** \`${finding.scannerType} rule: ${finding.ruleId}\`\n\n` : ''}
 ${screenshotSection ?? ''}
 To fix this, ${finding.solutionShort}.
 ${solutionLong ? `\nSpecifically:\n\n${solutionLong}` : ''}

.github/actions/file/src/openIssue.ts

@@ -1,11 +1,28 @@
 import type {Octokit} from '@octokit/core'
 import type {Finding} from './types.d.js'
 import {generateIssueBody} from './generateIssueBody.js'
+import {createHash} from 'node:crypto'
 import * as url from 'node:url'
 const URL = url.URL
 
 /** Max length for GitHub issue titles */
 const GITHUB_ISSUE_TITLE_MAX_LENGTH = 256
+/** Max length for GitHub label names */
+const GITHUB_LABEL_NAME_MAX_LENGTH = 50
+const RULE_LABEL_HASH_LENGTH = 4
+
+function createRuleLabel(scannerType: string, ruleId: string): string {
+  const label = `${scannerType} rule: ${ruleId}`
+  const characters = Array.from(label)
+
+  if (characters.length <= GITHUB_LABEL_NAME_MAX_LENGTH) {
+    return label
+  }
+
+  const hash = createHash('sha256').update(label).digest('hex').slice(0, RULE_LABEL_HASH_LENGTH)
+  const prefixLength = GITHUB_LABEL_NAME_MAX_LENGTH - hash.length - 1
+  return `${characters.slice(0, prefixLength).join('')}-${hash}`
+}
 
 /**
  * Truncates text to a maximum length, adding an ellipsis if truncated.
@@ -25,7 +42,7 @@ export async function openIssue(octokit: Octokit, repoWithOwner: string, finding
   const labels = [`${primary.scannerType}-scanning-issue`]
   // Only include a ruleId label when it's defined
   if (primary.ruleId) {
-    labels.push(`${primary.scannerType} rule: ${primary.ruleId}`)
+    labels.push(createRuleLabel(primary.scannerType, primary.ruleId))
   }
   // Flag non-WCAG findings so they can be filtered or triaged separately
   if (primary.category && primary.category !== 'wcag') {

.github/actions/file/tests/generateIssueBody.test.ts

@@ -24,12 +24,26 @@ describe('generateIssueBody', () => {
     const body = generateIssueBody(baseFinding, 'github/accessibility-scanner')
 
     expect(body).toContain('## What')
+    expect(body).toContain('**Rule:** `axe rule: color-contrast`')
     expect(body).toContain('## Acceptance Criteria')
     expect(body).toContain('The specific violation reported in this issue is no longer reproducible.')
     expect(body).toContain('The fix MUST meet WCAG 2.2 guidelines OR')
     expect(body).not.toContain('Specifically:')
   })
 
+  it('omits the rule line when the finding has no ruleId', () => {
+    const body = generateIssueBody(findingWithEmptyOptionalFields, 'github/accessibility-scanner')
+
+    expect(body).not.toContain('**Rule:**')
+  })
+
+  it('includes the full rule ID when its label would be shortened', () => {
+    const ruleId = 'keyboard-accessible/scrollable-region-with-an-extra-long-description'
+    const body = generateIssueBody({...baseFinding, ruleId}, 'github/accessibility-scanner')
+
+    expect(body).toContain(`**Rule:** \`axe rule: ${ruleId}\``)
+  })
+
   it('formats solutionLong lines into bullets while preserving Fix any/Fix all lines', () => {
     const body = generateIssueBody(
       {

.github/actions/file/tests/openIssue.test.ts

@@ -1,4 +1,5 @@
 import {describe, it, expect, vi} from 'vitest'
+import {createHash} from 'node:crypto'
 
 // Mock generateIssueBody so we can inspect what screenshotRepo is passed
 vi.mock('../src/generateIssueBody.js', () => ({
@@ -65,6 +66,33 @@ describe('openIssue', () => {
     )
   })
 
+  it('shortens long rule labels with a deterministic hash suffix', async () => {
+    const octokit = mockOctokit()
+    const ruleId = 'keyboard-accessible/scrollable-region-with-an-extra-long-description'
+    const fullLabel = `axe rule: ${ruleId}`
+    await openIssue(octokit, 'org/repo', [{...baseFinding, ruleId}])
+
+    const labels = octokit.request.mock.calls[0][1].labels
+    const ruleLabel = labels[1]
+    const hash = createHash('sha256').update(fullLabel).digest('hex').slice(0, 4)
+
+    expect(ruleLabel).toBe(`${fullLabel.slice(0, 45)}-${hash}`)
+    expect(Array.from(ruleLabel)).toHaveLength(50)
+  })
+
+  it('produces distinct labels for different long rule IDs', async () => {
+    const firstOctokit = mockOctokit()
+    const secondOctokit = mockOctokit()
+    const commonPrefix = 'keyboard-accessible/scrollable-region-with-a-long-description-'
+    await openIssue(firstOctokit, 'org/repo', [{...baseFinding, ruleId: `${commonPrefix}first`}])
+    await openIssue(secondOctokit, 'org/repo', [{...baseFinding, ruleId: `${commonPrefix}second`}])
+
+    const firstLabel = firstOctokit.request.mock.calls[0][1].labels[1]
+    const secondLabel = secondOctokit.request.mock.calls[0][1].labels[1]
+    expect(firstLabel.slice(0, 45)).toBe(secondLabel.slice(0, 45))
+    expect(firstLabel).not.toBe(secondLabel)
+  })
+
   it('adds a category label for non-WCAG findings', async () => {
     const octokit = mockOctokit()
     await openIssue(octokit, 'org/repo', [{...baseFinding, category: 'best-practice'}])

.github/actions/find/README.md

@@ -35,6 +35,10 @@ configuration option.
 [`colorScheme`](https://playwright.dev/docs/api/class-browser#browser-new-context-option-color-scheme)
 configuration option.
 
+#### `ignore_https_errors`
+
+**Optional** Bool - whether to ignore HTTPS errors when scanning URLs with self-signed certificates.
+
 #### `include_screenshots`
 
 **Optional** Bool - whether to capture screenshots of scanned pages and include links to them in the issue

.github/actions/find/action.yml

@@ -25,6 +25,11 @@ inputs:
   color_scheme:
     description: 'Playwright colorScheme setting: https://playwright.dev/docs/api/class-browser#browser-new-context-option-color-scheme'
     required: false
+  ignore_https_errors:
+    description: 'Whether to ignore HTTPS errors when scanning URLs with self-signed certificates'
+    required: false
+    default: 'false'
+
 outputs:
   findings_file:
     description: 'Path to a JSON file containing the list of potential accessibility gaps'

.github/actions/find/src/findForUrl.ts

@@ -23,6 +23,7 @@ export async function findForUrl(
   includeScreenshots: boolean = false,
   reducedMotion?: ReducedMotionPreference,
   colorScheme?: ColorSchemePreference,
+  ignoreHttpsErrors: boolean = false,
 ): Promise<Finding[]> {
   const {url, excludeSelectors, waitForSelectors} = urlConfig
   const browser = await playwright.chromium.launch({
@@ -33,6 +34,7 @@ export async function findForUrl(
     ...(authContext?.toPlaywrightBrowserContextOptions() ?? {}),
     ...(reducedMotion ? {reducedMotion} : {}),
     ...(colorScheme ? {colorScheme} : {}),
+    ...(ignoreHttpsErrors ? {ignoreHTTPSErrors: true} : {}),
   }
   let context: playwright.BrowserContext | undefined
   try {

.github/actions/find/src/index.ts

@@ -11,6 +11,7 @@ export default async function () {
   const urls = loadUrls({urlConfigs})
   const reducedMotion = loadReducedMotion()
   const colorScheme = loadColorScheme()
+  const ignoreHttpsErrors = loadIgnoreHttpsErrors()
 
   const actualUrls = urlConfigs || urls || []
 
@@ -22,7 +23,14 @@ export default async function () {
   for (const urlConfig of actualUrls) {
     const {url} = urlConfig
     core.info(`Preparing to scan ${url}`)
-    const findingsForUrl = await findForUrl(urlConfig, authContext, includeScreenshots, reducedMotion, colorScheme)
+    const findingsForUrl = await findForUrl(
+      urlConfig,
+      authContext,
+      includeScreenshots,
+      reducedMotion,
+      colorScheme,
+      ignoreHttpsErrors,
+    )
     if (findingsForUrl.length === 0) {
       core.info(`No accessibility gaps were found on ${url}`)
       continue
@@ -108,3 +116,7 @@ function loadColorScheme() {
 
   return colorSchemeInput as ColorSchemePreference
 }
+
+function loadIgnoreHttpsErrors() {
+  return core.getInput('ignore_https_errors', {required: false}).toLowerCase() === 'true'
+}

.github/actions/find/tests/findForUrl.test.ts

@@ -392,4 +392,35 @@ describe('findForUrl', () => {
       expect(await categoryFor(['wcag2a', 'experimental'])).toBe('experimental')
     })
   })
+
+  describe('when ignoreHttpsErrors is enabled', () => {
+    it('forwards ignoreHTTPSErrors to the browser context', async () => {
+      actionInput = ''
+      clearAll()
+
+      await findForUrl({url: 'test.com'}, undefined, false, undefined, undefined, true)
+
+      expect(playwrightMocks.browserNewContext).toHaveBeenCalledWith({ignoreHTTPSErrors: true})
+    })
+  })
+
+  describe('when ignoreHttpsErrors is not enabled', () => {
+    it('does not forward ignoreHTTPSErrors by default', async () => {
+      actionInput = ''
+      clearAll()
+
+      await findForUrl({url: 'test.com'})
+
+      expect(playwrightMocks.browserNewContext).toHaveBeenCalledWith({})
+    })
+
+    it('does not forward ignoreHTTPSErrors when explicitly disabled', async () => {
+      actionInput = ''
+      clearAll()
+
+      await findForUrl({url: 'test.com'}, undefined, false, undefined, undefined, false)
+
+      expect(playwrightMocks.browserNewContext).toHaveBeenCalledWith({})
+    })
+  })
 })

.github/actions/find/tests/index.test.ts

@@ -43,7 +43,7 @@ describe('url_configs', () => {
 
     await find()
 
-    expect(mocks.findForUrl).toHaveBeenCalledWith(urlConfig, expect.anything(), false, undefined, undefined)
+    expect(mocks.findForUrl).toHaveBeenCalledWith(urlConfig, expect.anything(), false, undefined, undefined, false)
   })
 
   it('rejects waitForSelectors values that are not arrays of strings', async () => {

.github/workflows/lint.yml

@@ -26,7 +26,7 @@ jobs:
         uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
 
       - name: Setup Node
-        uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
+        uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0
         with:
           node-version: 24
           cache: npm

.github/workflows/test.yml

@@ -34,7 +34,7 @@ jobs:
         uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
 
       - name: Setup Ruby
-        uses: ruby/setup-ruby@14594264cd68ce8a2345dd349bc3d138a4ef85c8
+        uses: ruby/setup-ruby@26e5b7d197ebf60545ee9667bcbace0be11ccaec
         with:
           ruby-version: '3.4'
           bundler-cache: true
@@ -80,7 +80,7 @@ jobs:
           repository: ${{ env.TESTING_REPOSITORY }}
           token: ${{ secrets.GH_TOKEN }}
           cache_key: ${{ steps.cache_key.outputs.cache_key }}
-          scans: '["axe", "reflow-scan"]'
+          scans: '["axe", "reflow-scan", "accesslint"]'
 
       - name: Retrieve cached results
         uses: ./.github/actions/gh-cache/restore

README.md

@@ -61,6 +61,7 @@ jobs:
           # dry_run: false # Optional: Set to true to scan and log what would be filed without creating/closing issues or writing the cache
           # reduced_motion: no-preference # Optional: Playwright reduced motion configuration option
           # color_scheme: light # Optional: Playwright color scheme configuration option
+          # ignore_https_errors: false # Optional: Set to true to ignore HTTPS errors when scanning URLs with self-signed certificates
           # scans: '["axe","accesslint","reflow-scan"]' # Optional: An array of scans (or plugins) to be performed. Built-in engines are 'axe' and 'accesslint'; any other entry is a plugin name. If not provided, only Axe will be performed.
           # url_configs: '[{"url":"https://example.com","excludeSelectors":["iframe","#widget"],"waitForSelectors":["#app","[data-ready]"]}]' # Optional: Per-URL config with CSS selectors to exclude from Axe or wait for before scanning. When provided, takes precedence over 'urls'.
 ```
@@ -137,6 +138,7 @@ Trigger the workflow manually or automatically based on your configuration. The
 | `file_experimental_issues`  | No       | Whether to file issues for experimental findings (checks that are not yet stable). Set to `false` to suppress new experimental issues; existing ones are left untouched. Default: `true`                                                                         | `false`                                                                     |
 | `reduced_motion`            | No       | Playwright `reducedMotion` setting for scan contexts. Allowed values: `reduce`, `no-preference`                                                                                                                                                                  | `reduce`                                                                    |
 | `color_scheme`              | No       | Playwright `colorScheme` setting for scan contexts. Allowed values: `light`, `dark`, `no-preference`                                                                                                                                                             | `dark`                                                                      |
+| `ignore_https_errors`       | No       | Whether to ignore HTTPS errors when scanning URLs with self-signed certificates. Default: `false`                                                                                                                                                                | `true`                                                                      |
 | `scans`                     | No       | An array of scans (or plugins) to be performed. Built-in engines are `axe` and `accesslint`; any other entry is treated as a plugin name. If not provided, only Axe will be performed.                                                                           | `'["axe", "accesslint", ...other plugins]'`                                 |
 | `dry_run`                   | No       | When `true`, scan and log the issues that _would_ be filed without opening, closing, reopening, or assigning any issues — and without writing to the `gh-cache` branch. Useful for safely previewing results. Default: `false`                                   | `true`                                                                      |
 | `url_configs`               | No       | A stringified JSON array of URL config objects. Each object must have a `url` field and may have `excludeSelectors` (selectors to exclude from Axe) and `waitForSelectors` (selectors that must become visible within 30 seconds before scanning). When provided, takes precedence over the `urls` input. | `'[{"url":"https://example.com","excludeSelectors":["iframe","#widget"],"waitForSelectors":["#app"]}]'` |

action.yml

@@ -63,6 +63,10 @@ inputs:
   color_scheme:
     description: 'Playwright colorScheme setting: https://playwright.dev/docs/api/class-browser#browser-new-context-option-color-scheme'
     required: false
+  ignore_https_errors:
+    description: 'Whether to ignore HTTPS errors when scanning URLs with self-signed certificates'
+    required: false
+    default: 'false'
   scans:
     description: "Stringified JSON array of scans to perform. Core engines and local plugins use string names. Allowlisted NPM plugins use an object with 'name', 'package', and optional 'version'. If not provided, only Axe will be performed"
     required: false
@@ -123,6 +127,7 @@ runs:
         login_url: ${{ inputs.login_url }}
         username: ${{ inputs.username }}
         password: ${{ inputs.password }}
+        ignore_https_errors: ${{ inputs.ignore_https_errors }}
     - name: Find
       id: find
       uses: ./../../_actions/github/accessibility-scanner/current/.github/actions/find
@@ -133,6 +138,7 @@ runs:
         include_screenshots: ${{ inputs.include_screenshots }}
         reduced_motion: ${{ inputs.reduced_motion }}
         color_scheme: ${{ inputs.color_scheme }}
+        ignore_https_errors: ${{ inputs.ignore_https_errors }}
         scans: ${{ inputs.scans }}
     - name: File
       id: file