Add support for an explicit remote path prefix#4014
Conversation
There was a problem hiding this comment.
Warning
- Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.
Pull request overview
Adds an explicit :: prefix to disambiguate remote CodeQL configuration paths.
Changes:
- Adds local/remote path prefix handling.
- Refactors remote address parsing and test helpers.
- Expands local and remote configuration tests.
Show a summary per file
| File | Description |
|---|---|
src/config/file.ts |
Defines local and remote path prefixes. |
src/config-utils.ts |
Routes prefixed paths and loads configurations. |
src/config-utils.test.ts |
Tests local and remote path handling. |
src/config/remote-file.ts |
Extracts new-format address parsing. |
src/testing-utils.ts |
Exports a minimal assertion interface. |
lib/entry-points.js |
Generated artifact; excluded from review. |
Review details
Files excluded by content exclusion policy (1)
- lib/entry-points.js
- Files reviewed: 5/6 changed files
- Comments generated: 4
- Review effort level: Medium
henrymercer
left a comment
There was a problem hiding this comment.
Bike shed about the prefix, but otherwise LGTM!
| * are restricted to ASCII characters, '.', and '-'. The prefix chosen here does not interfere with | ||
| * those and is _unlikely_ (but not impossible) to appear in a local file path. | ||
| */ | ||
| export const REMOTE_PATH_PREFIX = "::"; |
There was a problem hiding this comment.
What about something like remote:? It's five additional characters but can't be confused with two : separator characters.
There was a problem hiding this comment.
I have no strong feelings on :: and am happy to change it to something else, but I don't think that remote: would be a good choice because, if you have a repo in your organisation named remote, e.g. remote:codeql.yml would be a valid remote file address that instructs us to fetch codeql.yml from org/remote, and a remote: prefix would clash with that and cause us to truncate it to just codeql.yml. That's why I think the prefix should start with a character that's not allowed in repo or org names.
There was a problem hiding this comment.
Good point, how about remote=org/repo@ref:path or remote(org/repo@ref:path)?
There was a problem hiding this comment.
I have changed the prefix to remote= in 3492b7e
There was a problem hiding this comment.
Warning
- Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.
Review details
Files excluded by content exclusion policy (1)
- lib/entry-points.js
- Files reviewed: 5/6 changed files
- Comments generated: 1
- Review effort level: Medium
This is an alternative to #4012 which addresses the same issue. The first few commits here are the same as there and increase test coverage and refactor a couple of functions.
The approach to resolving the issue here is different, however: instead of trying to find the file locally as in #4012 and always treat ambiguous paths as remote paths, we instead add support for a prefix that allows user to explicitly indicate that a configuration file path is supposed to refer to a remote file.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
dynamicworkflows (Default Setup, Code Quality, ...).Products:
analysis-kinds: code-scanning.analysis-kinds: code-quality.Environments:
github.comand/or GitHub Enterprise Cloud with Data Residency.How did/will you validate this change?
.test.tsfiles).pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist