Swift: Adopt the smaller macOS host libraries - #22452
Conversation
Point at the staging artifact built with the x86_64-only thinning from semmle-code. Must be reverted before merging. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 03df685d-b0f4-4920-8c7c-8e70c6c868bf
The semmle-code change now thins only `usr/lib/swift/host`, so test that artifact rather than the earlier one which also thinned the per-target libraries.
henrymercer
changed the title
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The change updates a large binary/toolchain resource via Git LFS, and the correctness of the new archive’s contents (beyond the pointer metadata) can’t be validated from the diff alone.
Review tier: Lite
Findings: None
What changed in this PR
Updates the Swift macOS resource archive used by the Swift toolchain integration to a smaller, host-thinned variant, reducing the checked-in Git LFS artifact size while keeping the Swift version pinned at 6.3.3.
Changes:
- Replaces
swift/third_party/resources/resource-dir-macos.zip(Git LFS pointer) with a new object ID and smaller recorded size.
| File | Description |
|---|---|
| swift/third_party/resources/resource-dir-macos.zip | Updates the Git LFS pointer to the new, smaller macOS Swift resource archive. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
I did a DCA run on this PR, and that was successful. I'm not actually sure to what extent that tests the host libraries that have been updated here. How do you feel about the tested-ness of this PR? I'm certainly keen to see the archive size go down. |
We mainly discussed this on the internal PR. I've pinged you on it, but the tl;dr is that @redsun82 was happy to proceed. |
Replace the macOS Swift resource archive with the host-only thinned version and remove the staging override. This reduces the archive from 548 MB to 433 MB.
Only the host libraries are thinned to x64. Target SDK/runtime libraries and module metadata are unchanged, and Swift remains at 6.3.3.