Skip to content

Rust: Remove experimental flag to codeql_pack rule - #22530

Merged
paldepind merged 1 commit into
mainfrom
rust/remove-experimental
Sep 18, 2026
Merged

paldepind merged 1 commit into
mainfrom
rust/remove-experimental

Conversation

@paldepind

Copy link
Copy Markdown
Contributor

I'm guessing we no longer need this. @redsun82 should probably confirm :)

@github-actions github-actions Bot added the Rust Pull requests that update Rust code label Sep 9, 2026
@paldepind
paldepind marked this pull request as ready for review September 9, 2026 11:07
@paldepind
paldepind requested a review from a team as a code owner September 9, 2026 11:07
Copilot AI balanced review requested due to automatic review settings September 9, 2026 11:07
@paldepind
paldepind requested a review from redsun82 September 9, 2026 11:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused change has been fully reviewed with no unresolved issues.

Review tier: Balanced
Findings: None

What changed in this PR

Removes obsolete experimental packaging for the stable Rust extractor.

Changes:

  • Removes the experimental flag.
  • Stops generating the duplicate experimental/rust pack.
File Description
rust/​BUILD.bazel Removes the experimental flag from the Rust pack definition.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@redsun82 redsun82 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I'm actually surprised this is still around, and the rust package has long not been in the experimental directory in the release. I suspect this might have become a no-op, but in the meantime it definitely needs to go here 🙂 thanks for spotting this!

@redsun82

redsun82 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

ah, I see, experimental = True just duplicates the pack creating another rust-experimental target, that downstream consumers can chose to use or not. So yeah, this is dead weight at the moment.

@paldepind
paldepind merged commit 473f974 into main Sep 18, 2026
17 checks passed
@paldepind
paldepind deleted the rust/remove-experimental branch September 18, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants