Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Two moderate findings remain in CachePoisoningQuery.qll concerning tags-ignore handling and implicit caller-mode propagation.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite (auto)
Findings: 1
Note
Copilot is running an experiment and ran this review at Lite.
Open (1)
What changed in this PR
Updates CodeQL’s GitHub Actions cache-poisoning analysis for the new cache-mode syntax, reusable-workflow limits, and trigger scenarios.
Changes:
- Adds cache-mode AST accessors and effective-mode analysis.
- Expands cache-write and cache-poisoning fixtures, triggers, and expected results.
- Updates CWE-349 documentation and query/library change notes.
| File | Reviewed change |
|---|---|
actions/ql/test/query-tests/Security/CWE-349/CacheWriteAccess.ql |
Adds cache-mode cache-write behavior tests. |
actions/ql/test/query-tests/Security/CWE-349/CacheWriteAccess.expected |
Records expected cache-write results. |
actions/ql/test/query-tests/Security/CWE-349/CachePoisoningViaPoisonableStep.expected |
Updates expected poisonable-step results. |
actions/ql/test/query-tests/Security/CWE-349/CachePoisoningViaDirectCache.expected |
Updates expected direct-cache results. |
actions/ql/test/query-tests/Security/CWE-349/CachePoisoningViaCodeInjection.expected |
Updates expected code-injection results. |
actions/ql/test/query-tests/Security/CWE-349/.github/workflows/poisonable_step1.yml |
Adds poisonable-step workflow coverage. |
actions/ql/test/query-tests/Security/CWE-349/.github/workflows/direct_cache1.yml |
Adds direct-cache workflow coverage. |
actions/ql/test/query-tests/Security/CWE-349/.github/workflows/code_injection1.yml |
Adds code-injection workflow coverage. |
actions/ql/test/query-tests/Security/CWE-349/.github/workflows/cache_write_capable_workflow_dispatch.yml |
Adds workflow-dispatch trigger coverage. |
actions/ql/test/query-tests/Security/CWE-349/.github/workflows/cache_write_capable_reusable_workflow_caller.yml |
Adds reusable-workflow caller coverage. |
actions/ql/test/query-tests/Security/CWE-349/.github/workflows/cache_write_capable_push.yml |
Adds push-trigger coverage. |
actions/ql/test/query-tests/Security/CWE-349/.github/workflows/cache_write_capable_pull_request.yml |
Adds pull-request trigger coverage. |
actions/ql/test/query-tests/Security/CWE-349/.github/workflows/cache_mode_reusable.yml |
Adds reusable-workflow cache-mode coverage. |
actions/ql/test/query-tests/Security/CWE-349/.github/workflows/cache_mode_nested.yml |
Adds nested cache-mode coverage. |
actions/ql/src/Security/CWE-349/CachePoisoningViaPoisonableStep.md |
Documents cache-mode guidance. |
actions/ql/src/Security/CWE-349/CachePoisoningViaDirectCache.md |
Documents cache-mode guidance. |
actions/ql/src/Security/CWE-349/CachePoisoningViaCodeInjection.md |
Documents cache-mode guidance. |
actions/ql/src/change-notes/2026-09-17-cache-mode.md |
Documents query behavior changes. |
actions/ql/lib/codeql/actions/security/CachePoisoningQuery.qll |
Implements cache-mode and trigger analysis. Two moderate findings remain: tags-ignore handling suppresses valid default-branch findings (2 votes), and implicit caller-mode propagation can incorrectly allow write callees (1 vote). |
actions/ql/lib/codeql/actions/ast/internal/Ast.qll |
Adds internal cache-mode accessors. |
actions/ql/lib/codeql/actions/Ast.qll |
Exposes cache-mode accessors. |
actions/ql/lib/change-notes/2026-09-17-cache-mode.md |
Documents library and API changes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
/cc: @gregose |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.blog/changelog/2026-09-10-control-github-actions-cache-access-with-cache-mode/