Skip to content

unified: Make data flow tests valid #22617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
asgerf wants to merge 1 commit into
base: main
Choose a base branch
from
+514 −498
Draft

unified: Make data flow tests valid #22617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 45 additions & 40 deletions unified/ql/test/library-tests/dataflow/implicit-self.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
func source(_ s: String) -> String { return s }

@discardableResult
func sink(_ s: String) -> String { return "" }

class Box {
var x: String = ""
}
Expand All @@ -7,78 +12,78 @@ class C {
var box = Box()

func t1() {
sink(self.x); // no flow
self.x = source("t1.1");
sink(self.x); // $ hasValueFlow=t1.1
sink(self.x) // no flow
self.x = source("t1.1")
sink(self.x) // $ hasValueFlow=t1.1
}

func t2() {
sink(x); // no flow
x = source("t2.1");
sink(x); // $ hasValueFlow=t2.1
sink(x) // no flow
x = source("t2.1")
sink(x) // $ hasValueFlow=t2.1
}

func t3() {
sink(self.x); // no flow
x = source("t3.1");
sink(self.x); // $ hasValueFlow=t3.1
sink(self.x) // no flow
x = source("t3.1")
sink(self.x) // $ hasValueFlow=t3.1
}

func t4() {
sink(x); // no flow
self.x = source("t4.1");
sink(x); // $ hasValueFlow=t4.1
sink(x) // no flow
self.x = source("t4.1")
sink(x) // $ hasValueFlow=t4.1
}

func t5() {
sink(self.box.x); // no flow
self.box.x = source("t5.1");
sink(self.box.x); // $ hasValueFlow=t5.1
sink(self.box.x) // no flow
self.box.x = source("t5.1")
sink(self.box.x) // $ hasValueFlow=t5.1
}

func t6() {
sink(box.x); // no flow
box.x = source("t6.1");
sink(box.x); // $ hasValueFlow=t6.1
sink(box.x) // no flow
box.x = source("t6.1")
sink(box.x) // $ hasValueFlow=t6.1
}

func t7() {
sink(self.box.x); // no flow
box.x = source("t7.1");
sink(self.box.x); // $ hasValueFlow=t7.1
sink(self.box.x) // no flow
box.x = source("t7.1")
sink(self.box.x) // $ hasValueFlow=t7.1
}

func t8() {
sink(box.x); // no flow
self.box.x = source("t8.1");
sink(box.x); // $ hasValueFlow=t8.1
sink(box.x) // no flow
self.box.x = source("t8.1")
sink(box.x) // $ hasValueFlow=t8.1
}

func t9() {
x = "safe";
x += sink(x) + source("t9.1");
sink(x); // $ hasTaintFlow=t9.1
sink(self.x); // $ hasTaintFlow=t9.1
x = "safe"
x += sink(x) + source("t9.1")
sink(x) // $ hasTaintFlow=t9.1
sink(self.x) // $ hasTaintFlow=t9.1
}

func t10() {
x = "safe";
self.x += sink(x) + source("t10.1");
sink(x); // $ hasTaintFlow=t10.1
sink(self.x); // $ hasTaintFlow=t10.1
x = "safe"
self.x += sink(x) + source("t10.1")
sink(x) // $ hasTaintFlow=t10.1
sink(self.x) // $ hasTaintFlow=t10.1
}

func t11() {
self.x = "safe";
x += sink(x) + source("t11.1");
sink(x); // $ hasTaintFlow=t11.1
sink(self.x); // $ hasTaintFlow=t11.1
self.x = "safe"
x += sink(x) + source("t11.1")
sink(x) // $ hasTaintFlow=t11.1
sink(self.x) // $ hasTaintFlow=t11.1
}

func t12() {
self.x = "safe";
self.x += sink(x) + source("t12.1");
sink(x); // $ hasTaintFlow=t12.1
sink(self.x); // $ hasTaintFlow=t12.1
self.x = "safe"
self.x += sink(x) + source("t12.1")
sink(x) // $ hasTaintFlow=t12.1
sink(self.x) // $ hasTaintFlow=t12.1
}
}
Loading
Loading