Unified: Improve toString of UnaryExpr, BinaryExpr, CallExpr, and MemberAccessExpr. - #22618
Merged
Merged
Conversation
aschackmull
added
the
no-change-note-required
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementations are consistent with the AST schema and the updated tests cover each formatting path.
Review effort: Balanced
Findings: None
What changed in this PR
Improves Unified AST string representations for common expression types.
Changes:
- Adds operator-, member-, and callee-aware
toString()implementations. - Updates control-flow annotations and generated expectations.
| File | Description |
|---|---|
FacadeAst.qll |
Implements improved expression formatting. |
cfg.swift |
Updates inline CFG expectations. |
cfg.expected |
Updates generated CFG results. |
basicblock-slices.expected |
Updates generated block-slice results. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
aschackmull
force-pushed
the
unified/ast-tostring
branch
from
September 18, 2026 09:17
1f8c8b1 to
fa56fb4
Compare
hvitved
reviewed
Sep 18, 2026
Co-authored-by: Tom Hvitved <hvitved@github.com>
hvitved
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.