Unified: Fix compilation in printCfg. - #22625
Merged
Merged
Conversation
aschackmull
added
the
no-change-note-required
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The refactoring preserves the implementation while resolving type visibility without expanding the public facade.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes Unified printCfg compilation while keeping the control-flow AST adapter out of the public unified facade.
Changes:
- Moves the
AstSigimplementation into an internal module. - Imports and qualifies
Ast::CallableinprintCfg.
| File | Description |
|---|---|
unified/ql/lib/ide-contextual-queries/printCfg.ql |
Uses the accessible control-flow callable type. |
unified/ql/lib/codeql/unified/internal/ControlFlowGraphImpl.qll |
Hosts the extracted AST adapter. |
unified/ql/lib/codeql/unified/internal/ControlFlowGraph.qll |
Privately imports the adapter. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hvitved
approved these changes
Sep 18, 2026
hvitved
requested changes
Sep 18, 2026
hvitved
left a comment
hvitved
left a comment
Contributor
There was a problem hiding this comment.
unified/ql/lib/ide-contextual-queries/printCfg.ql still doesn't compile.
aschackmull
force-pushed
the
unified/printcfg-fix
branch
from
September 18, 2026 11:55
ae1c737 to
d72e82e
Compare
Contributor
Author
I think it does - I think it's just the CI check, which also tries to compile main. |
aschackmull
force-pushed
the
unified/printcfg-fix
branch
from
September 18, 2026 12:00
d72e82e to
aab5d00
Compare
hvitved
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the Ast module public,
but moves it to another file, so it's not exposed inimport unified.