fix outline helper not closing on app close - #352
Merged
Conversation
Collaborator
|
I looked at the code changes. It looks good. |
|
🚀 New build available for commit |
|
🚀 New build available for commit |
gr5
approved these changes
Aug 3, 2026
gr5
left a comment
gr5
left a comment
Collaborator
There was a problem hiding this comment.
Code looks good. I built and ran this with QT5 (of course I will test the QT6 build on next release). It closes the jitter window (outline helper) when you close the app.
atsju
marked this pull request as ready for review
August 4, 2026 06:54
Collaborator
Author
|
Thank you for your test @gr5. I hadn't tested it yet. Hence the "draft" pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix one of the windows not closing identified in #82
This PR modernizes Outline Helper lifecycle management by replacing its static singleton access with a MainWindow-owned dialog instance.
The intent is to make window behavior more predictable: the dialog now follows Qt parent-child ownership, so it closes naturally with the main window.
It also improves separation of concerns by having the dialog emit user-intent signals (Start/Stop), while MainWindow handles the actual processing logic. This keeps UI code focused on interaction and makes behavior easier to reason about, test, and maintain over time.