Repository navigation
Conversation
Ceilometer passes original resource IDs to many Gnocchi resource API functions, even if they are not UUIDs. Gnocchi allows this, but converts them to resource UUIDs based on the authenticated user and project.
Ceilometer publishes Swift containers to Gnocchi using IDs in the format `{project_id}_{container_name}`. Container names can be made up of any characters up to 256 characters long, including special characters such as the ones used in URL escapes.
To ensure such resource IDs are parsed by Gnocchi correctly, escape them using `urllib.parse.quote` before appending to URLs where required.
Contributor
Author
|
@tobias-urdin Looks like the pipeline needs some work. |
Contributor
|
The CI will be fixed by #154 when merged. |
Contributor
|
can you compare this PR to this one that I've missed #152 and see which one you prefer, seems to be the same issue |
Contributor
Author
I have made comments on improvements that should be made to #152, but on the whole I prefer the solution of having a separate encoding method for If #152 does not get a timely response, I am happy to update my change to incorporate some of the improvements of that one. |
Contributor
Author
|
Closed in favour of: #152 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ceilometer passes original resource IDs to many Gnocchi resource API functions, even if they are not UUIDs. Gnocchi allows this, but converts them to resource UUIDs based on the authenticated user and project.
Ceilometer publishes Swift containers to Gnocchi using IDs in the format
{project_id}_{container_name}. Container names can be made up of any characters up to 256 characters long, including special characters such as the ones used in URL escapes.To ensure such resource IDs are parsed by Gnocchi correctly, escape them using
urllib.parse.quotebefore appending to URLs where required.