Skip to content

merge queue: checking #152 on master (b2e2058) - #159

Closed
mergify[bot] wants to merge 4 commits into
masterfrom
mergify/merge-queue/fb6b602f0e
Closed

mergify[bot] wants to merge 4 commits into
masterfrom
mergify/merge-queue/fb6b602f0e

Conversation

@mergify

@mergify mergify Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Note

This is a merge queue draft opened by Mergify. Nobody needs to act on it.
Mergify opened it for batch circular-andouille-ee6tcx of the duplicated default from automatic merge queue, to test #152 before it merges into master. Pushing to this branch or closing this pull request removes #152 from the queue.

What this draft tests

Mergify checks that #152 still passes CI on top of master. CI runs on this draft's code, built in this order:

  1. master at b2e2058
  2. #152, the pull request of this batch

🎉 Where it stands: checks passed

CI passed on this draft.

Follow the duplicated default from automatic merge queue in the dashboard

What happens next

  • Mergify merges #152 into master and closes this draft.
Metadata for CI tooling, read by mergify ci
---
all_scopes: false
checking_base_sha: b2e20589d39fed043fdde62bd144e4753d99ab23
previous_check_retries: []
previous_failed_batches: []
pull_requests:
  - number: 152
    scopes: []
scopes: []
...
Required conditions of queue rule duplicated default from automatic merge for merge
  • check-success=test (build)
  • check-success=test (docs-gnocchi-web)
  • check-success=test (pep8)
  • check-success=test (py310)
  • check-success=test (py311)
  • check-success=test (py312)
Required conditions to stay in the queue

fivetime and others added 4 commits October 17, 2026 15:31
Resource ids are free-form strings server-side (anything that is not a
UUID gets hashed into one), and real-world ids contain characters that
are significant in a URL. Cinder reports storage pools as
"<host>@<backend>#<pool>"; putting that id raw into the path turns
everything from '#' on into a URL fragment, so resource show/update/
delete and metric-by-resource requests land on "<host>@<backend>" -- a
different, usually nonexistent resource -- and fail with 404.

The Ceilometer gnocchi publisher hits this on every polled
volume.provider.pool.capacity.* sample that carries resource attributes:
the initial creation works (the id travels in the batch body) but the
attribute update never does.

Add utils.encode_resource_id() (urllib.parse.quote with safe="", so
that a '/' in an id is encoded as well) and apply it wherever a
resource id is spliced into a path.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
testtools is not one of this repository's test dependencies, so the
module failed to import in an environment installed from .[test].
The tests only use assertEqual and assertTrue; use unittest.TestCase
like the other unit tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mergify mergify Bot closed this Oct 26, 2026
@mergify
mergify Bot deleted the mergify/merge-queue/fb6b602f0e branch October 26, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant