Repository navigation
merge queue: checking #152 on master (b2e2058) - #159
Closed
mergify[bot] wants to merge 4 commits into
Closed
mergify[bot] wants to merge 4 commits into
mergify[bot] wants to merge 4 commits into
Conversation
Resource ids are free-form strings server-side (anything that is not a UUID gets hashed into one), and real-world ids contain characters that are significant in a URL. Cinder reports storage pools as "<host>@<backend>#<pool>"; putting that id raw into the path turns everything from '#' on into a URL fragment, so resource show/update/ delete and metric-by-resource requests land on "<host>@<backend>" -- a different, usually nonexistent resource -- and fail with 404. The Ceilometer gnocchi publisher hits this on every polled volume.provider.pool.capacity.* sample that carries resource attributes: the initial creation works (the id travels in the batch body) but the attribute update never does. Add utils.encode_resource_id() (urllib.parse.quote with safe="", so that a '/' in an id is encoded as well) and apply it wherever a resource id is spliced into a path. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…client into fix/encode-resource-id
testtools is not one of this repository's test dependencies, so the module failed to import in an environment installed from .[test]. The tests only use assertEqual and assertTrue; use unittest.TestCase like the other unit tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is a merge queue draft opened by Mergify. Nobody needs to act on it.
Mergify opened it for batch circular-andouille-ee6tcx of the
duplicated default from automatic mergequeue, to test #152 before it merges intomaster. Pushing to this branch or closing this pull request removes #152 from the queue.What this draft tests
Mergify checks that #152 still passes CI on top of
master. CI runs on this draft's code, built in this order:masteratb2e2058🎉 Where it stands: checks passed
CI passed on this draft.
Follow the
duplicated default from automatic mergequeue in the dashboardWhat happens next
masterand closes this draft.Metadata for CI tooling, read by
mergify ciRequired conditions of queue rule
duplicated default from automatic mergefor mergecheck-success=test (build)check-success=test (docs-gnocchi-web)check-success=test (pep8)check-success=test (py310)check-success=test (py311)check-success=test (py312)Required conditions to stay in the queue
#approved-reviews-by>=1check-success=test (build)check-success=test (docs-gnocchi-web)check-success=test (pep8)check-success=test (py310)check-success=test (py311)check-success=test (py312)label!=work-in-progress