Repository navigation
Conversation
Control for whether the call.rs:289 lingering-reference assertion in the smoke suite is pre-existing. No code change. Signed-off-by: Johan Mjönes <johan@playgoals.com>
Author
|
Control complete. Both
Both pre-existing; #1 is clear. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway control. Empty commit on
main, no code change.Purpose: establish whether the
lore/src/call.rs:289assertion failure in the smoke suite ("Repository has strong reference remaining after completion") is pre-existing on unmodifiedmain, or introduced by #1.If smoke fails here too, it is pre-existing and #1 is clear. Closing as soon as the run reports.