Fix release notes shell injection in create_release workflow - #169
Merged
Conversation
By interpolating the changelog entry into a double quoted bash string, bash parsed the contents for commands. When the changelog entry included backticks for a code block, bash tried to execute it. Passing via the env context avoids this.
jamiecobbett
enabled auto-merge
September 1, 2026 13:58
jcardozagc
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`resource_type: x`) were interpolated directly into a double-quoted bash string in the release step, causing bash to treat the backticks as command substitution instead of literal text.env:context instead, so the value is expanded as a shell variable rather than re-parsed as script text.Same fix as gocardless/gocardless-pro-python#146, which hit this in production when a v3.7.0 changelog entry contained backticked code.
Test plan