WPA-14407: Added CLI support for panel based email services - #212
WPA-14407: Added CLI support for panel based email services#212sgimpel-godaddy wants to merge 6 commits into
Conversation
| } | ||
|
|
||
| fn first_eligible_account_id(data: &Value) -> Option<String> { | ||
| data.get("eligibleAccounts")? |
There was a problem hiding this comment.
Not blocking, but I think a good backlog enhancement would be to switch this client to being spec-generated so that we have strongly-typed structures and avoid accidental data shape mismatches.
|
I'd recommend attaching a markdown guide to the command module as well, just to explain the email system, things like what is an account ID, etc. |
There was a problem hiding this comment.
If you reformat this to do soft line breaks instead of hard breaks, then cli-engine's markdown-to-terminal formatting takes care of word wrapping based on the terminal width instead.
| An **account** (`accountId`) identifies an existing GoDaddy Email/productivity | ||
| account the customer already holds under panel-v3. It's an opaque ID scoped to | ||
| this API — it is **not** a shopper/customer ID, and it has nothing to do with | ||
| domain or hosting "accounts" elsewhere in `gddy`. A customer may hold zero, | ||
| one, or several eligible email accounts; `email create` needs to know which | ||
| one to provision the new mailbox under. |
There was a problem hiding this comment.
Seems to be explaining things to us, not to users ("a customer" versus "you"). Is "productivity" a term that customers will understand? Will they understand "panel-v3?" Also, I'm not sure this explains an account sufficiently. Is there an account per domain name? Per inbox? This doesn't make it clear why we have accounts as a distinct thing from their login account or their domain name. I'm just wondering if account ID is something this CLI needs to have at all.
Co-authored-by: Jacob Page <85361835+jpage-godaddy@users.noreply.github.com>
2 participants
No description provided.