Skip to content

feat(cli): right-align numeric table columns - #219

Merged
jpage-godaddy merged 1 commit into
mainfrom
right-aligned-columns
Aug 19, 2026
Merged

feat(cli): right-align numeric table columns#219
jpage-godaddy merged 1 commit into
mainfrom
right-aligned-columns

Conversation

@jpage-godaddy

Copy link
Copy Markdown
Collaborator

Summary

  • Bumps cli-engine to 0.8.6, which adds TableColumn::align(Alignment::Right) and auto-right-aligns numeric columns for commands with no explicit view (e.g. api domain list's endpoints count, api search/api operation list's graphqlOperations count now line up with no gddy code changes needed).
  • Right-aligns price/count columns in gddy's own explicit views:
    • domain available/domain quote: price columns, including the nested terms (per-registration-term pricing) and fees (premium domain surcharge) tables
    • domain suggest: added a new explicit view (it had none before) so its per-term prices right-align — this is the command where ragged decimal points were actually visible to users today
    • dns add/dns delete/dns set: record counts (created/failed/deleted/replaced)

Test plan

  • cargo check
  • cargo clippy -- -D warnings
  • cargo test (660 passing)
  • cargo fmt --check
  • ./scripts/check-module-size.sh
  • Manually verified rendered output for domain available, domain suggest, api domain list — prices/counts line up on the decimal/least-significant digit

🤖 Generated with Claude Code

Bumps cli-engine to 0.8.6 (adds TableColumn::align and auto-right-aligns
numeric columns in commands with no explicit view, e.g. api domain
list's endpoints count) and right-aligns price/count columns declared
by gddy's own explicit views: domain available/quote's price columns
(including the nested terms/fees tables), domain suggest's per-term
prices (which needed a new explicit view, since it previously had
none), and dns add/delete/set's record counts.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 18, 2026 23:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves table readability by right-aligning numeric/price columns in CLI output. It does this primarily via a cli-engine bump (enabling right-alignment for numeric columns when no explicit view is defined) and by explicitly aligning price/count columns in commands that define custom views.

Changes:

  • Bump cli-engine from 0.8.4 to 0.8.6 to pick up table column alignment support and numeric auto-alignment.
  • Add an explicit view for gddy domain suggest so its formatted currency strings right-align (and align on decimal places).
  • Update existing views in domain and DNS commands to explicitly right-align price/count columns, including nested tables.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
rust/src/domain/suggest.rs Adds an explicit view and right-aligns formatted currency string columns for cleaner suggestion pricing output.
rust/src/domain/quote.rs Right-aligns top-level and nested fee amount price columns in the quote view.
rust/src/domain/available.rs Right-aligns nested per-term pricing columns in the availability view.
rust/src/dns/set/mod.rs Right-aligns replaced/created/deleted count columns in the DNS set view.
rust/src/dns/delete.rs Right-aligns deleted/failed count columns in the DNS delete view.
rust/src/dns/add.rs Right-aligns created/failed count columns in the DNS add view.
rust/Cargo.toml Bumps cli-engine dependency to 0.8.6.
rust/Cargo.lock Updates lockfile for cli-engine 0.8.6.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@jpage-godaddy
jpage-godaddy merged commit 2647579 into main Aug 19, 2026
5 checks passed
@jpage-godaddy
jpage-godaddy deleted the right-aligned-columns branch August 19, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants