feat(cli): right-align numeric table columns - #219
Merged
Conversation
Bumps cli-engine to 0.8.6 (adds TableColumn::align and auto-right-aligns numeric columns in commands with no explicit view, e.g. api domain list's endpoints count) and right-aligns price/count columns declared by gddy's own explicit views: domain available/quote's price columns (including the nested terms/fees tables), domain suggest's per-term prices (which needed a new explicit view, since it previously had none), and dns add/delete/set's record counts. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves table readability by right-aligning numeric/price columns in CLI output. It does this primarily via a cli-engine bump (enabling right-alignment for numeric columns when no explicit view is defined) and by explicitly aligning price/count columns in commands that define custom views.
Changes:
- Bump
cli-enginefrom0.8.4to0.8.6to pick up table column alignment support and numeric auto-alignment. - Add an explicit view for
gddy domain suggestso its formatted currency strings right-align (and align on decimal places). - Update existing views in domain and DNS commands to explicitly right-align price/count columns, including nested tables.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rust/src/domain/suggest.rs | Adds an explicit view and right-aligns formatted currency string columns for cleaner suggestion pricing output. |
| rust/src/domain/quote.rs | Right-aligns top-level and nested fee amount price columns in the quote view. |
| rust/src/domain/available.rs | Right-aligns nested per-term pricing columns in the availability view. |
| rust/src/dns/set/mod.rs | Right-aligns replaced/created/deleted count columns in the DNS set view. |
| rust/src/dns/delete.rs | Right-aligns deleted/failed count columns in the DNS delete view. |
| rust/src/dns/add.rs | Right-aligns created/failed count columns in the DNS add view. |
| rust/Cargo.toml | Bumps cli-engine dependency to 0.8.6. |
| rust/Cargo.lock | Updates lockfile for cli-engine 0.8.6. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
qcai-godaddy
approved these changes
Aug 19, 2026
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cli-engineto 0.8.6, which addsTableColumn::align(Alignment::Right)and auto-right-aligns numeric columns for commands with no explicit view (e.g.api domain list'sendpointscount,api search/api operation list'sgraphqlOperationscount now line up with no gddy code changes needed).domain available/domain quote: price columns, including the nestedterms(per-registration-term pricing) andfees(premium domain surcharge) tablesdomain suggest: added a new explicit view (it had none before) so its per-term prices right-align — this is the command where ragged decimal points were actually visible to users todaydns add/dns delete/dns set: record counts (created/failed/deleted/replaced)Test plan
cargo checkcargo clippy -- -D warningscargo test(660 passing)cargo fmt --check./scripts/check-module-size.shdomain available,domain suggest,api domain list— prices/counts line up on the decimal/least-significant digit🤖 Generated with Claude Code