Repository navigation
docs(rules): the mock-lies rule covers every stand-in - #52
Merged
Merged
Conversation
Three of the four fixes since the last pass were a fake kinder than the real thing: the in-memory Keychain's delete could not fail, every test held one spelling of a domain, and the test browser downloads a CSV the app's WKWebView displays. The section named only mock_gam.sh. It now covers the Keychain fake and the app window too, and names the tripwires that hold them to the real thing. Pre-commit item 6 matches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The improve-rules pass over everything since 2026-10-01: the fix commits b6feae3, 383100a, 6947456 and
5f8193e, the failure-log entries, the two open ledger entries, and failed CI runs.
Finding: known mode, weak wording. Three of the four fixes share one shape, a test stand-in kinder
than the real thing:
second tenant (6947456);
CLAUDE.md's "mock lies" section names only
tests/fixtures/mock_gam.sh, so it read as a rule about theGAM mock. This edit says it covers every stand-in (the Keychain fake, the app window, GAM) and names the
tripwires that hold them to the real thing. Pre-commit item 6 says the same. This also resolves the
2026-10-08 ledger entry, which asked for an app-window corollary.
No new invariant, no renumbering. The ledger records the other verdicts: 383100a and the hook-test
incident were not rules problems, and the 2026-10-02 entry (#3's wording) is the next candidate, since
this PR makes one change.
How it was verified
.venv/bin/python -m pytest -qpasses_KeyringBackend.delete_password, 11 tests intest_vault.pyfail; withdownloaddropped from theAudit export link,
test_every_link_to_a_download_route_carries_the_download_attributefails; bothpass once restored
make lint/ a11y: n/a (docs only)If it builds or runs a
gamcommandn/a
Live status: n/a (docs only).
Nothing private
🤖 Generated with Claude Code