Conversation
Mobile.md and GoArm.md embedded screenshots via http:// URLs. On the HTTPS go.dev site these are mixed content: browsers block them or must silently upgrade the request, so the images can fail to display. Switch the five image references (four i.imgur.com, one farm8.staticflickr.com) to https://. All five hosts already serve the same files over https.
|
This PR (HEAD: 1e25e5c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/wiki/+/804800. Important tips:
|
|
Message from Sean Liao: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/804800. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Mobile.mdandGoArm.mdembed screenshots viahttp://URLs. Because https://go.dev is served over HTTPS, these are mixed content: browsers either block the request or must silently upgrade it, so the images can fail to display.Affected references:
Mobile.md— 4×http://i.imgur.com/…GoArm.md— 1×http://farm8.staticflickr.com/…Fix
Switch the five references to
https://. Each host already serves the identical file over HTTPS (verified: imgur →200 image/png, flickr →200 image/jpeg), so this is a scheme-only change with no other content edits.Companion to #102, which fixes the
/blob/module-diagram images. Together they make every embedded image on the wiki load reliably on the HTTPS site.