fix: initialize schedule_free step_count to zero - #1744
Open
wahid18-maqs wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an off-by-one issue in
schedule_freeby initializingstep_countto0instead of1.Changes
ScheduleFreeState.step_countto0.step_countis zero, and0.Why
Previously,
step_countwas initialized to1while the learning-rate schedule was queried before the counter was incremented. As a result, the first optimizer update skipped the schedule's step-0 value, leading to incorrect behavior for schedules that depend on the initial step (e.g. warmup schedules).This change aligns
schedule_freewith the behavior of other stateful optimizers in Optax and ensures the first scheduled learning rate is applied as intended.