fix(transforms): reset notfinite_count after apply_if_finite gives up and accepts non-finite update - #1746
Open
wahid18-maqs wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the
apply_if_finitestate tracking by resettingnotfinite_countafter the optimizer gives up and accepts a non-finite update.Changes
notfinite_countto0on the step whereapply_if_finiteexceedsmax_consecutive_errorsand accepts the update.pmappath as well.Why
Previously,
notfinite_countcontinued to increase afterapply_if_finiteexceededmax_consecutive_errorsand accepted a non-finite update. This caused the counter to represent the total accumulated non-finite updates rather than the current streak of consecutive failures.Resetting the counter after the give-up step makes its behavior consistent with its intended semantics and provides more meaningful diagnostic information during training.