Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IMAS output wrote vacuum_toroidal_field.r0 = R_major and b0 at each slice's R_major. When R_major changes over time, this gives an inconsistent multi-slice IDS (r0 comes from the first slice only), and coupled codes that keep a fixed r0 slowly lose the vacuum field. Geometry now keeps the input reference radius as an optional r0_vacuum, filled by the IMAS loader, and both the equilibrium and core_profiles outputs write b0 at that r0, or at the first slice's R_major if none was given, with r0·b0 unchanged.