Repository navigation
Fix IMAS sign of B0 and v_loop in core_profiles I/O - #2933
Open
MireilleSchneider wants to merge 1 commit into
Open
MireilleSchneider wants to merge 1 commit into
MireilleSchneider wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TORAX converts its positive internal currents to the IMAS COCOS convention by flipping Ip and the current densities when writing
core_profiles, and the equilibrium writer flips B0. The core_profiles writer did not flip
vacuum_toroidal_field.b0norglobal_quantities.v_loop, so for a standard ITER case (Ip < 0, B0 < 0) the output had b0 > 0 and v_loop with the sign of the internal current. This violates the COCOS 17 consistencyrule sign(q) = sign(Ip * B0)checked by IMAS-Validator, and gives a loop voltage of the wrong sign relative to Ip (v_loop is an "ip_like" COCOS quantity, independent of B0).consistent with the Ip flip already applied on input (B0 is already
read as an absolute value).