Skip to content

Specify Swift names for GIDClaim methods #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
w-goog merged 2 commits into from
Aug 28, 2026
+7 −4
Merged

Specify Swift names for GIDClaim methods #627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6182869
g-orchestrated: pin the Swift names of the GIDClaim factory methods
w-goog Aug 27, 2026
013a799
g-orchestrated: note the GIDClaim Swift name pinning in the changelog
w-goog Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Unreleased
- Pinned the Swift names of the `GIDClaim` factory methods with explicit `NS_SWIFT_NAME` annotations. The imported Swift names are unchanged (`authTime()`, `essentialAuthTime()`, `amr()` and `essentialAMR()`); they no longer depend on the Objective-C importer's implicit renaming heuristics.

# 9.2.0
- Expose the refresh token expiration date ([#577](https://github.com/google/GoogleSignIn-iOS/pull/577))
- Support requesting the `amr` (Authentication Methods References) claim ([#600](https://github.com/google/GoogleSignIn-iOS/pull/600))
Expand Down
8 changes: 4 additions & 4 deletions GoogleSignIn/Sources/Public/GoogleSignIn/GIDClaim.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,16 +38,16 @@ extern NSString *const kAMRClaimName;
#pragma mark - Factory Methods

/// Creates a *non-essential* (voluntary) "auth_time" claim object.
+ (instancetype)authTimeClaim;
+ (instancetype)authTimeClaim NS_SWIFT_NAME(authTime());

/// Creates an *essential* "auth_time" claim object.
+ (instancetype)essentialAuthTimeClaim;
+ (instancetype)essentialAuthTimeClaim NS_SWIFT_NAME(essentialAuthTime());

/// Creates a *non-essential* (voluntary) "amr" claim object.
+ (instancetype)AMRClaim;
+ (instancetype)AMRClaim NS_SWIFT_NAME(amr());

/// Creates an *essential* "amr" claim object.
+ (instancetype)essentialAMRClaim;
+ (instancetype)essentialAMRClaim NS_SWIFT_NAME(essentialAMR());

@end

Expand Down
Loading