Skip to content

Fix SignInSample import + add to CI #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
w-goog wants to merge 5 commits into
base: main
Choose a base branch
from
+35 −1
Open

Fix SignInSample import + add to CI #632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
262833e
g-orchestrated: import AppAuth as a module in SignInSample
w-goog Aug 28, 2026
1274f20
g-orchestrated: build SignInSample in CI for both dependency managers
w-goog Aug 28, 2026
dd531e4
Merge branch 'main' into fix/signinsample-spm-appauth-import
w-goog Aug 28, 2026
df80415
Merge branch 'main' into fix/signinsample-spm-appauth-import
w-goog Aug 28, 2026
532e19f
g-orchestrated: build the SignInSample CI jobs for a generic simulator
w-goog Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions .github/workflows/unit_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,40 @@ jobs:
-destination ${{ matrix.destination }} \
test-without-building

signin-sample-spm-build:
runs-on: macos-15
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
- name: Select Xcode
run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer
- name: Build SignInSample (SPM)
run: |
xcodebuild \
-project Samples/ObjC/SignInSample/SignInSample.xcodeproj \
-scheme SignInSample \
-destination "generic/platform=iOS Simulator" \
build

signin-sample-pods-build:
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
runs-on: macos-15
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
- name: Select Xcode
run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer
- name: Update Bundler
run: bundle update --bundler
- name: Install Ruby gems with Bundler
run: bundle install
- name: Install pods
run: bundle exec pod install --project-directory=Samples/ObjC/SignInSample
- name: Build SignInSample (CocoaPods)
run: |
xcodebuild \
-workspace Samples/ObjC/SignInSample/SignInSampleForPod.xcworkspace \
-scheme SampleForPod \
-destination "generic/platform=iOS Simulator" \
build
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed

xcode-27-preview-test:
# Build and run the unit tests against the Xcode 27 preview image. Xcode 27
# beta is the only (thus, default) Xcode on that image, so no xcode-select
Expand Down
2 changes: 1 addition & 1 deletion Samples/ObjC/SignInSample/Source/SignInViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@
#import "SignInViewController.h"

@import GoogleSignIn;
@import AppAuth;

#import "AuthInspectorViewController.h"
#import "DataPickerState.h"
#import "DataPickerViewController.h"
#import <AppAuth/OIDTokenUtilities.h>

static NSString *const kSignInViewTitle = @"Sign-In Sample";
static NSString *const kPlaceholderUserName = @"<Name>";
Expand Down
Loading