fix: parse token exp claim for expiration clamp - #112
Open
paulb777 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #16573
AppCheckCorepreviously derived a cached token'sexpirationDatefrom the local time at which the client happens to process the HTTP response, rather than from the token's ownexpclaim. Because every downstream validity decision reads only that locally-derived value, any delay between the App Check backend minting a token and the client executing the response handler is silently converted into extra apparent lifetime. This can cause the SDK to serve an already-expired token for up to a full TTL if the process is suspended or stalled between the token request and the response handling.This PR addresses the issue by explicitly parsing the JSON Web Token (
expclaim) from the App Check token payload returned by the server.It then computes
expirationDate = min(jwtExpirationDate, requestDate + ttl)clamping it to the correct bounds.If the token is a mock token or malformed, it gracefully falls back to the original
requestDate + ttllogic.Changes
expclaim inGACAppCheckTokenExpirationDateFromJWT.initWithResponseDict:insideGACAppCheckToken+APIResponseto compute the clamped expiration date based on the extractedexp.GACAppCheckAPIServiceTests.m:testAppCheckTokenWithAPIResponseValidJWTWithExpandtestAppCheckTokenWithAPIResponseValidJWTWithExpGreaterThenTTLto verify correctexpirationDateextraction and clamping behavior when a valid JWT payload is intercepted.