Hardening: Adopt safe buffer models, bounds-checked roots, and verifier pointer safety - #9267
Open
jagadish-chandra-vantimi wants to merge 2 commits into
Conversation
…er pointer safety - Adopt total-ordering pointer range validation in verifier (CheckPointerInRange) to avoid pointer relational comparison UB and wrap hazards. - Validate FlexBuffers scalar widths to powers of two (1, 2, 4, 8) and enforce buffer length sufficiency on root parsing. - Mitigate integer overflow in size-prefixed buffer verification. - Enforce structural vtable size minimums (vsize >= 4) and reject metadata offsets (< 4) in GetOptionalFieldOffset. - Propagate depth and table count budgets across nested FlatBuffers verification. - Introduce canonical GetVerifiedRoot<T> and GetVerifiedSizePrefixedRoot<T> safe entrypoints. - Add GetOptional, GetSafe, and MutateSafe to Vector and Array primitives. - Add comprehensive unit tests in MemorySafetyHardeningTest.
jagadish-chandra-vantimi
requested a review
from dbaileychess
as a code owner
September 20, 2026 17:33
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This patch introduces proactive memory-safety hardening and safe buffer abstractions across core FlatBuffers parsing and verification infrastructure:
FlexBuffers Root Width Validation (
flexbuffers.h):Pointer Range & Relational Comparison Safety (
verifier.h):uintptr_ttotal-ordering pointer range checking (CheckPointerInRange) across verifier entrypoints to prevent undefined behavior in pointer relational operations and avoid pointer wrap hazards.size_ - sizeof(SizeT)) to prevent integer overflow wrapping.vsize >= 2 * sizeof(voffset_t)), cleanly rejecting degenerate tables.Secure-by-Design Verification APIs (
verifier.h):GetVerifiedRoot<T>andGetVerifiedSizePrefixedRoot<T>inflatbuffers/verifier.hso consuming applications can verify and deserialize buffer roots in a single atomic call.Table Offset Validation (
table.h):< 4) and unaligned field indices inGetOptionalFieldOffset.Safe Buffer Model & Bounds-Checked Accessors (
vector.h,array.h,stl_emulation.h,buffer_ref.h):GetOptional(i),GetSafe(i, default), and runtime bounds-checkedMutateSafe(i, val)to vectors and arrays.spanintegration across detached buffers, buffer references, and root accessors.Automated Testing (
tests/test.cpp):MemorySafetyHardeningTestcovering all boundary conditions, malformed header rejections, safe mutation routines, and verified root extraction.