This repository was archived by the owner on Aug 4, 2026. It is now read-only.
Rename unused for loop variable _ instead of i - #80
Open
paruby wants to merge 1 commit into
Open
Conversation
…ed and this makes it harder to read
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
paruby
marked this pull request as draft
May 10, 2025 10:40
paruby
marked this pull request as ready for review
May 10, 2025 10:40
Author
|
Hmm i signed the CLA but the check is still failing. Maybe it needs some time to propagate or it needs to somehow be re-triggered manually but i'm not sure how to do that |
Author
|
Ah it was my bad about the CLA thing, I had not clicked through the link to refresh the check I don't see a button to submit the PR, does that have to be triggered on your side @MayankChaturvedi ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to understand the code and found it a little confusing because the
iwasn't used in that for loop, but there was another below where it was used.(I'm a googler, let me know if it is better to make a commit internally instead of publicly)