Update existingLoiFeatures to depend on camera bounds - #3887
Merged
andreia-ferreira merged 7 commits intoAug 21, 2026
Conversation
andreia-ferreira
requested a deployment
to
e2e-approval
August 18, 2026 16:45 — with
GitHub Actions
Waiting
andreia-ferreira
requested a deployment
to
e2e-approval
August 19, 2026 07:46 — with
GitHub Actions
Waiting
shobhitagarwal1612
approved these changes
Aug 20, 2026
…ng-features-within-bounds # Conflicts: # app/src/main/java/org/groundplatform/android/ui/datacollection/DataCollectionViewModel.kt # app/src/test/java/org/groundplatform/android/ui/common/BaseMapViewModelTest.kt
andreia-ferreira
requested a deployment
to
e2e-approval
August 21, 2026 08:03 — with
GitHub Actions
Waiting
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3887 +/- ##
=========================================
Coverage 68.79% 68.80%
- Complexity 1928 1929 +1
=========================================
Files 412 411 -1
Lines 10971 10958 -13
Branches 1432 1428 -4
=========================================
- Hits 7548 7540 -8
+ Misses 2676 2673 -3
+ Partials 747 745 -2
🚀 New features to boost your workflow:
|
andreia-ferreira
deleted the
andreia/3866/existing-features-within-bounds
branch
August 21, 2026 10:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3866
This PR improves the previously introduced
existingLoiFeatures, combining it with thegetCurrentCameraPositionflow in order to only render the features within the bounds. This prevents potential OOMs due to the fact that these features, drawn in the drop pin/draw area screens, are not clusterable, so they'd all be rendered at once if not bounded.It also removes the uneeded extension
launchWhenTaskVisiblewhich was required for when the data collection was a view pager.@shobhitagarwal1612 PTAL?