Skip to content

Fix update of maps utils - #3894

Open
andreia-ferreira wants to merge 4 commits into
masterfrom
andreia/google-maps-utils-update
Open

Fix update of maps utils#3894
andreia-ferreira wants to merge 4 commits into
masterfrom
andreia/google-maps-utils-update

Conversation

@andreia-ferreira

Copy link
Copy Markdown
Collaborator

android-maps-utils was rewritten in Kotlin in v5, and this broke some things during compilation in the dependabot PR (#3841), so this is addressed here instead:

  • FeatureClusterItem should now override the interface properties instead of the old getters
  • FeatureClusterManager couldn't extend ClusterManager anymore, since that is now final, so it now sets its own gmsClusterManager. Some new helper methods were added because of that

@shobhitagarwal1612 PTAL?

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.82%. Comparing base (83d559d) to head (a994b14).

Files with missing lines Patch % Lines
.../android/ui/map/gms/features/FeatureClusterItem.kt 25.00% 3 Missing ⚠️
...droid/ui/map/gms/features/FeatureClusterManager.kt 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3894      +/-   ##
============================================
+ Coverage     68.80%   68.82%   +0.01%     
- Complexity     1929     1933       +4     
============================================
  Files           411      411              
  Lines         10958    10968      +10     
  Branches       1428     1428              
============================================
+ Hits           7540     7549       +9     
- Misses         2673     2674       +1     
  Partials        745      745              
Files with missing lines Coverage Δ
...roid/ui/map/gms/features/FeatureClusterRenderer.kt 57.69% <ø> (ø)
...form/android/ui/map/gms/features/FeatureManager.kt 67.50% <100.00%> (+0.41%) ⬆️
...droid/ui/map/gms/features/FeatureClusterManager.kt 76.92% <92.30%> (+6.33%) ⬆️
.../android/ui/map/gms/features/FeatureClusterItem.kt 40.00% <25.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants