Skip to content

Only forbid DISABLED registrars in the console - #3188

Merged
gbrodman merged 1 commit into
google:masterfrom
gbrodman:allowPendingRegistrarsConsole
Jul 30, 2026
Merged

Only forbid DISABLED registrars in the console#3188
gbrodman merged 1 commit into
google:masterfrom
gbrodman:allowPendingRegistrarsConsole

Conversation

@gbrodman

@gbrodman gbrodman commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

PENDING registrars may just need to add contacts etc in order to be enabled, and they should be able to use the console to do so.

#3162 was a bit too aggressive


This change is Reviewable

@gbrodman
gbrodman requested a review from CydeWeys July 30, 2026 18:29

@CydeWeys CydeWeys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's worth linking to the previous PR related to this change in the commit description.

@CydeWeys made 1 comment.
Reviewable status: 0 of 2 files reviewed, all discussions resolved.

@gbrodman gbrodman left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@gbrodman made 1 comment.
Reviewable status: 0 of 2 files reviewed, all discussions resolved.

@CydeWeys CydeWeys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CydeWeys reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on gbrodman).


core/src/test/java/google/registry/ui/server/console/domains/ConsoleBulkDomainActionTest.java line 255 at r1 (raw file):

  @Test
  void testFailure_pendingRegistrar() {

Should this be a test success pending registrar?

PENDING registrars may just need to add contacts etc in order to be
enabled, and they should be able to use the console to do so.
@gbrodman
gbrodman force-pushed the allowPendingRegistrarsConsole branch from 32c26a3 to b6c88e3 Compare July 30, 2026 20:00

@gbrodman gbrodman left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbrodman made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on CydeWeys).


core/src/test/java/google/registry/ui/server/console/domains/ConsoleBulkDomainActionTest.java line 255 at r1 (raw file):

Previously, CydeWeys (Ben McIlwain) wrote…

Should this be a test success pending registrar?

meh i don't think it really matters much, but sure -- i put this in the users action because it doesn't make much sense to have domain-retrieval tests for pending registrars

@CydeWeys CydeWeys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@CydeWeys made 1 comment and resolved 1 discussion.
Reviewable status: 2 of 3 files reviewed, all discussions resolved.

@CydeWeys CydeWeys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CydeWeys reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on gbrodman).

@gbrodman
gbrodman enabled auto-merge July 30, 2026 20:02
@gbrodman
gbrodman added this pull request to the merge queue Jul 30, 2026
Merged via the queue into google:master with commit 92b684d Jul 30, 2026
16 checks passed
@gbrodman
gbrodman deleted the allowPendingRegistrarsConsole branch July 30, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants