Only forbid DISABLED registrars in the console - #3188
Conversation
CydeWeys
left a comment
There was a problem hiding this comment.
It's worth linking to the previous PR related to this change in the commit description.
@CydeWeys made 1 comment.
Reviewable status: 0 of 2 files reviewed, all discussions resolved.
gbrodman
left a comment
There was a problem hiding this comment.
done
@gbrodman made 1 comment.
Reviewable status: 0 of 2 files reviewed, all discussions resolved.
CydeWeys
left a comment
There was a problem hiding this comment.
@CydeWeys reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on gbrodman).
core/src/test/java/google/registry/ui/server/console/domains/ConsoleBulkDomainActionTest.java line 255 at r1 (raw file):
@Test void testFailure_pendingRegistrar() {
Should this be a test success pending registrar?
PENDING registrars may just need to add contacts etc in order to be enabled, and they should be able to use the console to do so.
32c26a3 to
b6c88e3
Compare
gbrodman
left a comment
There was a problem hiding this comment.
@gbrodman made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on CydeWeys).
core/src/test/java/google/registry/ui/server/console/domains/ConsoleBulkDomainActionTest.java line 255 at r1 (raw file):
Previously, CydeWeys (Ben McIlwain) wrote…
Should this be a test success pending registrar?
meh i don't think it really matters much, but sure -- i put this in the users action because it doesn't make much sense to have domain-retrieval tests for pending registrars
CydeWeys
left a comment
There was a problem hiding this comment.
@CydeWeys made 1 comment and resolved 1 discussion.
Reviewable status: 2 of 3 files reviewed, all discussions resolved.
CydeWeys
left a comment
There was a problem hiding this comment.
@CydeWeys reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on gbrodman).
PENDING registrars may just need to add contacts etc in order to be enabled, and they should be able to use the console to do so.
#3162 was a bit too aggressive
This change is