Use Result<(), ...> types - #128
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_981099621
branch
from
September 16, 2026 06:33
418c558 to
5f2e925
Compare
Crubit now supports the unit type in certain situations like in Result<(), ...>, which means we can replace the dummy u8 we used there temporarily. Previous attempt had to be rolled back because it broke some usages. They are now fixed. PiperOrigin-RevId: 982300983
copybara-service
Bot
force-pushed
the
test_981099621
branch
from
September 16, 2026 06:43
5f2e925 to
9bb512d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Result<(), ...> types
Crubit now supports the unit type in certain situations like in Result<(), ...>, which means we can replace the dummy u8 we used there temporarily.
Previous attempt had to be rolled back because it broke some usages. They are now fixed.