Repository navigation
test: verify all 48 timestamp bits in UUID v7 - #233
Open
renanmpimentel wants to merge 1 commit into
Open
renanmpimentel wants to merge 1 commit into
renanmpimentel wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this test matters
A v7 implementation could discard the highest of its 48 timestamp bits yet pass tests using smaller times. This deterministic clock case checks the whole timestamp field and catches truncation above
2^40ms.Supertest audit method
I used the Supertest test-audit skill to probe whether the existing suite would catch a plausible violation of this contract. The regression was applied only in an isolated worktree. The regression proof records three executed states: the existing tests pass with that regression, the new assertion fails against the same regression, and the new test passes with the original production code restored. The published diff adds tests only.
Change and verification
Adds a deterministic public API test that checks all 48 timestamp bits in a UUID v7. It fixes the clock at
2 << 40Unix milliseconds and verifies the six timestamp bytes, then restores the shared clock and monotonic state.Regression proof: setting the highest timestamp byte to zero leaves the existing
go test ./...suite passing, but fails this assertion (000000000000instead of020000000000). With production code restored,go test ./...,go test -race ./...,go vet ./...,gofmt, andgit diff --checkpass.This PR changes tests only.
Repository guidance
CONTRIBUTING.mdasks for tests and a signed CLA. Tests, race tests, vet, and formatting passed locally; the GitHub CLA check currently fails, so contribution acceptance is pending that external requirement.