refactor(storage): fix ESLint and TS errors in internal tooling and conformance tests - #9213
Open
thiyaguk09 wants to merge 2 commits into
Open
refactor(storage): fix ESLint and TS errors in internal tooling and conformance tests#9213thiyaguk09 wants to merge 2 commits into
thiyaguk09 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces formatting updates and asynchronous handling improvements across the storage performance and conformance tests, such as awaiting bucket deletion, returning promises in cleanup routines, and using the void operator for unawaited main calls. The review feedback suggests simplifying performTestCleanup using a ternary operator to avoid manual type casting, handling potential errors in recordResult with a .catch() block instead of silencing it with void, and replacing the platform-dependent execSync call in performanceUtils.ts with native Node.js APIs to prevent command injection and ensure cross-platform compatibility.
… error handling in performance testing utilities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕