Skip to content

refactor(storage): fix ESLint and TS errors in internal tooling and conformance tests - #9213

Open
thiyaguk09 wants to merge 2 commits into
googleapis:mainfrom
thiyaguk09:fix/storage-tooling-conformance
Open

refactor(storage): fix ESLint and TS errors in internal tooling and conformance tests#9213
thiyaguk09 wants to merge 2 commits into
googleapis:mainfrom
thiyaguk09:fix/storage-tooling-conformance

Conversation

@thiyaguk09

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Aug 26, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces formatting updates and asynchronous handling improvements across the storage performance and conformance tests, such as awaiting bucket deletion, returning promises in cleanup routines, and using the void operator for unawaited main calls. The review feedback suggests simplifying performTestCleanup using a ternary operator to avoid manual type casting, handling potential errors in recordResult with a .catch() block instead of silencing it with void, and replacing the platform-dependent execSync call in performanceUtils.ts with native Node.js APIs to prevent command injection and ensure cross-platform compatibility.

Comment thread handwritten/storage/internal-tooling/performTransferManagerTest.ts Outdated
Comment thread handwritten/storage/internal-tooling/performanceTest.ts Outdated
Comment thread handwritten/storage/internal-tooling/performanceUtils.ts Outdated
… error handling in performance testing utilities
@thiyaguk09
thiyaguk09 marked this pull request as ready for review August 26, 2026 07:46
@thiyaguk09
thiyaguk09 requested a review from a team as a code owner August 26, 2026 07:46
@github-actions
github-actions Bot requested a review from feywind August 26, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant