Skip to content

build: Add open-telemetry/api dependency to Core and Gax - #9574

Closed
cy-yun wants to merge 2 commits into
googleapis:mainfrom
cy-yun:feat/observability-t2-otel-dep
Closed

build: Add open-telemetry/api dependency to Core and Gax#9574
cy-yun wants to merge 2 commits into
googleapis:mainfrom
cy-yun:feat/observability-t2-otel-dep

Conversation

@cy-yun

@cy-yun cy-yun commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Description

This PR implements Phase 1 Task 2 of the Client Libraries Observability v1 design.

Depends on #9573.

Changes

  • Adds the open-telemetry/api dependency to both Core and Gax composer.json files.
  • Relying directly on the community standard OpenTelemetry API avoids the maintenance burden of building and supporting custom abstraction wrappers. The OTel API is designed to safely no-op if an SDK is not present in the user's environment.

@cy-yun
cy-yun requested a review from a team as a code owner August 25, 2026 17:33
@cy-yun
cy-yun force-pushed the feat/observability-t2-otel-dep branch 2 times, most recently from d281448 to 775d6e2 Compare August 25, 2026 21:08
@cy-yun
cy-yun marked this pull request as draft August 25, 2026 21:16
@cy-yun
cy-yun force-pushed the feat/observability-t2-otel-dep branch from 79842f3 to 3167b4d Compare August 25, 2026 22:06
@cy-yun
cy-yun force-pushed the feat/observability-t2-otel-dep branch from 3167b4d to 48dc682 Compare August 26, 2026 07:02
@cy-yun
cy-yun marked this pull request as ready for review August 26, 2026 08:16

@bshaffer bshaffer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not need a separate PR just to add dependencies to Core and Gax. Please close this PR and we can review that change as part of the other PRs.

@cy-yun

cy-yun commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Combined into #9573 to avoid cascading PRs and simplify review.

@cy-yun cy-yun closed this Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants